Issue 220453008: Introduce ReadPositionFromRegister in x64 Regexp Macro Assembler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 220453008: Introduce ReadPositionFromRegister in x64 Regexp Macro Assembler (Closed)

Created:
6 years, 8 months ago by haitao.feng

Modified:
6 years, 8 months ago

Reviewers:
Toon Verwaest

CC:
v8-dev

Base URL:
https://v8.googlecode.com/svn/branches/bleeding_edge

Visibility:
Public.

Introduce ReadPositionFromRegister in x64 Regexp Macro Assembler R=verwaest@chromium.org Committed: https://code.google.com/p/v8/source/detail?r=20421

Created: 6 years, 8 months ago

Download [raw] [tar.bz2]

		Unified diffs	Side-by-side diffs	Delta from patch set	Stats (+28 lines, -8 lines)			Patch
	M	src/x64/regexp-macro-assembler-x64.h	View		1 chunk	+2 lines, -0 lines	0 comments	Download
	M	src/x64/regexp-macro-assembler-x64.cc	View		5 chunks	+26 lines, -8 lines	0 comments	Download

Total messages: 3 (0 generated)

haitao.feng

x32 uses 32-bit (kPointerSize) for the register_location. Normally we use movp instruction for them, but ...

6 years, 8 months ago (2014-04-01 14:42:54 UTC) #1

haitao.feng

6 years, 8 months ago (2014-04-02 03:01:58 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as r20421 (presubmit successful).