Fuchsia: Use low-level prng call, add test, update test runner.

Fuchsia: Use low-level prng call, add test, update test runner.

There is now a syscall for getting cryptographically secure random bytes.

R=asiva@google.com

Committed: https://github.com/dart-lang/sdk/commit/e476e00ca64694f443cc68842d38351501ee23df

[zra, 2016-08-01 20:11:19]

zra@google.com changed reviewers:
+ asiva@google.com

[zra, 2016-08-01 20:14:28]

Description was changed from

==========
Fuchsia: Use low-level prng call, add test, update test runner.
==========

to

==========
Fuchsia: Use low-level prng call, add test, update test runner.

There is now a syscall for getting a cryptographically secure random number.
==========

[zra, 2016-08-01 20:14:44]

Description was changed from

==========
Fuchsia: Use low-level prng call, add test, update test runner.

There is now a syscall for getting a cryptographically secure random number.
==========

to

==========
Fuchsia: Use low-level prng call, add test, update test runner.

There is now a syscall for getting cryptographically secure random bytes.
==========

[siva, 2016-08-02 19:55:14]

LGTM with one comment.

https://codereview.chromium.org/2204523002/diff/20001/runtime/bin/crypto_fuch...
File runtime/bin/crypto_fuchsia.cc (right):

https://codereview.chromium.org/2204523002/diff/20001/runtime/bin/crypto_fuch...
runtime/bin/crypto_fuchsia.cc:22: const mx_ssize_t res = mx_cprng_draw(buffer,
len);
doesn't buffer have to be updated to buffer+read ?

[zra, 2016-08-02 20:16:55]

https://codereview.chromium.org/2204523002/diff/20001/runtime/bin/crypto_fuch...
File runtime/bin/crypto_fuchsia.cc (right):

https://codereview.chromium.org/2204523002/diff/20001/runtime/bin/crypto_fuch...
runtime/bin/crypto_fuchsia.cc:22: const mx_ssize_t res = mx_cprng_draw(buffer,
len);
On 2016/08/02 19:55:13, siva wrote:
> doesn't buffer have to be updated to buffer+read ?

Oops. Yes.

[zra, 2016-08-02 20:18:40]

Description was changed from

==========
Fuchsia: Use low-level prng call, add test, update test runner.

There is now a syscall for getting cryptographically secure random bytes.
==========

to

==========
Fuchsia: Use low-level prng call, add test, update test runner.

There is now a syscall for getting cryptographically secure random bytes.

R=asiva@google.com

Committed:
https://github.com/dart-lang/sdk/commit/e476e00ca64694f443cc68842d38351501ee23df
==========

[zra, 2016-08-02 20:18:42]

Committed patchset #3 (id:40001) manually as
e476e00ca64694f443cc68842d38351501ee23df (presubmit successful).