ResizeObserver pt6: integration

third_party/WebKit/Source/core/dom/Element.cpp

 /*
  * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
  *           (C) 1999 Antti Koivisto (koivisto@kde.org)
  *           (C) 2001 Peter Kelly (pmk@post.com)
  *           (C) 2001 Dirk Mueller (mueller@kde.org)
  *           (C) 2007 David Smith (catfish.man@gmail.com)
  * Copyright (C) 2004, 2005, 2006, 2007, 2008, 2009, 2010, 2012, 2013 Apple Inc. All rights reserved.
  *           (C) 2007 Eric Seidel (eric@webkit.org)
  *
  * This library is free software; you can redistribute it and/or
@@ skipping 98 matching lines @@
 #include "core/html/HTMLSlotElement.h"
 #include "core/html/HTMLTableRowsCollection.h"
 #include "core/html/HTMLTemplateElement.h"
 #include "core/html/parser/HTMLParserIdioms.h"
 #include "core/input/EventHandler.h"
 #include "core/inspector/InspectorInstrumentation.h"
 #include "core/layout/LayoutTextFragment.h"
 #include "core/layout/api/LayoutBoxItem.h"
 #include "core/layout/api/LayoutViewItem.h"
 #include "core/loader/DocumentLoader.h"
+#include "core/observer/ResizeObservation.h"
 #include "core/page/ChromeClient.h"
 #include "core/page/FocusController.h"
 #include "core/page/Page.h"
 #include "core/page/PointerLockController.h"
 #include "core/page/SpatialNavigation.h"
 #include "core/page/scrolling/RootScrollerController.h"
 #include "core/page/scrolling/ScrollCustomizationCallbacks.h"
 #include "core/page/scrolling/ScrollState.h"
 #include "core/page/scrolling/ScrollStateCallback.h"
 #include "core/paint/PaintLayer.h"
@@ skipping 1487 matching lines @@
             document().activeChainNodeDetached(*this);
         document().userActionElements().didDetach(*this);
     }
 
     if (context.clearInvalidation)
         document().styleEngine().styleInvalidator().clearInvalidation(*this);
 
     if (svgFilterNeedsLayerUpdate())
         document().unscheduleSVGFilterLayerUpdateHack(*this);
 
+    sizeMayHaveChanged();
+
     DCHECK(needsAttach());
 }
 
 bool Element::pseudoStyleCacheIsInvalid(const ComputedStyle* currentStyle, ComputedStyle* newStyle)
 {
     DCHECK_EQ(currentStyle, computedStyle());
     DCHECK(layoutObject());
 
     if (!currentStyle)
         return false;
@@ skipping 1020 matching lines @@
     if (hasRareData())
         return elementRareData()->resizeObserverData();
     return nullptr;
 }
 
 HeapHashMap<Member<ResizeObserver>, Member<ResizeObservation>>& Element::ensureResizeObserverData()
 {
     return ensureElementRareData().ensureResizeObserverData();
 }
 
+void Element::sizeMayHaveChanged()
+{
+    HeapHashMap<Member<ResizeObserver>, Member<ResizeObservation>>* roData = resizeObserverData();

[esprehn, 2016/08/03 18:06:51]

don't abbreviate, I'd either call this |data| or |observerData|

[atotic1, 2016/08/04 23:59:39]

Done.

+    if (roData) {

[esprehn, 2016/08/03 18:06:51]

I'd early return:

if (!data)
  return;

You can en use auto here to make this function very compact.

if (auto* data = resizeObserverData()) {
  for (auto& observation : data->values())
    observation->elementSizeChanged()
}

[atotic1, 2016/08/04 23:59:39]

Done.

+        for (auto& iter : *roData)

[esprehn, 2016/08/03 18:06:51]

->values() and make the loop variable |observation|

[atotic1, 2016/08/04 23:59:39]

Done. Thanks for providing the solution. Still feeling my way around different
C++ collections and auto.

+            iter.value->elementSizeChanged();
+    }
+}
+
 // Step 1 of http://domparsing.spec.whatwg.org/#insertadjacenthtml()
 static Element* contextElementForInsertion(const String& where, Element* element, ExceptionState& exceptionState)
 {
     if (equalIgnoringCase(where, "beforeBegin") || equalIgnoringCase(where, "afterEnd")) {
         Element* parent = element->parentElement();
         if (!parent) {
             exceptionState.throwDOMException(NoModificationAllowedError, "The element has no parent.");
             return nullptr;
         }
         return parent;
@@ skipping 1093 matching lines @@
 
 DEFINE_TRACE_WRAPPERS(Element)
 {
     if (hasRareData()) {
         visitor->traceWrappers(elementRareData());
     }
     ContainerNode::traceWrappers(visitor);
 }
 
 } // namespace blink