Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(570)

Issue 2204443002: Use ChildThreadImpl::thread_safe_sender in font proxy if available (Closed)

Created:
4 years, 4 months ago by Ilya Kulshin
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

Use ChildThreadImpl::thread_safe_sender in font proxy if available This changes the logic that the font proxy uses to get the IPC sender. It will now try to get a sender in the initialization code, and use that one if available. This allows it to get the sender while it is still running on the main thread in the plugin, so that it can use it for IPCs later when called from a different thread. This is a threading violation, but it will allow the proxy to work when called by Flash from a background thread. BUG=631254 Review-Url: https://codereview.chromium.org/2182213004 Cr-Commit-Position: refs/heads/master@{#408551} (cherry picked from commit ddaf9994ab75ff143da0c2f5c44499e49db1815f) Committed: https://chromium.googlesource.com/chromium/src/+/b7b20301c408b1d22395353e68ee8887aac06d0a

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+11 lines, -1 line) Patch
M content/child/dwrite_font_proxy/dwrite_font_proxy_init_win.cc View 2 chunks +11 lines, -1 line 0 comments Download

Messages

Total messages: 2 (1 generated)
Ilya Kulshin
4 years, 4 months ago (2016-08-01 19:04:57 UTC) #2
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
b7b20301c408b1d22395353e68ee8887aac06d0a.

Powered by Google App Engine
This is Rietveld 408576698