Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(454)

Unified Diff: chrome/browser/search/search.cc

Issue 2204363003: Remove search::ShouldUseAltInstantURL and ShouldUseSearchPathForInstant (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: tests Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/browser/search/search.h ('k') | chrome/browser/search/search_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/browser/search/search.cc
diff --git a/chrome/browser/search/search.cc b/chrome/browser/search/search.cc
index aeb5e1a728cab54b425bf4e31a8e3f0b94adb22b..6680dea1d781ab862df9444c7630617239413318 100644
--- a/chrome/browser/search/search.cc
+++ b/chrome/browser/search/search.cc
@@ -52,13 +52,6 @@ namespace search {
namespace {
-// Controls whether to use the alternate Instant search base URL. This allows
-// experimentation of Instant search.
-const char kUseAltInstantURL[] = "use_alternate_instant_url";
-const char kUseSearchPathForInstant[] = "use_search_path_for_instant";
-const char kAltInstantURLPath[] = "search";
-const char kAltInstantURLQueryParams[] = "&qbp=1";
-
// Status of the New Tab URL for the default Search provider. NOTE: Used in a
// UMA histogram so values should only be added at the end and not reordered.
enum NewTabURLState {
@@ -479,17 +472,6 @@ GURL GetInstantURL(Profile* profile, bool force_instant_results) {
if (!IsURLAllowedForSupervisedUser(instant_url, profile))
return GURL();
- if (ShouldUseAltInstantURL()) {
- GURL::Replacements replacements;
- const std::string path(
- ShouldUseSearchPathForInstant() ? kAltInstantURLPath : std::string());
- if (!path.empty())
- replacements.SetPathStr(path);
- const std::string query(
- instant_url.query() + std::string(kAltInstantURLQueryParams));
- replacements.SetQueryStr(query);
- instant_url = instant_url.ReplaceComponents(replacements);
- }
return instant_url;
}
@@ -598,16 +580,4 @@ InstantSupportState GetInstantSupportStateFromNavigationEntry(
return StringToInstantSupportState(value);
}
-bool ShouldUseAltInstantURL() {
- FieldTrialFlags flags;
- return GetFieldTrialInfo(&flags) && GetBoolValueForFlagWithDefault(
- kUseAltInstantURL, false, flags);
-}
-
-bool ShouldUseSearchPathForInstant() {
- FieldTrialFlags flags;
- return GetFieldTrialInfo(&flags) && GetBoolValueForFlagWithDefault(
- kUseSearchPathForInstant, false, flags);
-}
-
} // namespace search
« no previous file with comments | « chrome/browser/search/search.h ('k') | chrome/browser/search/search_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698