Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(208)

Issue 2204363003: Remove search::ShouldUseAltInstantURL and ShouldUseSearchPathForInstant (Closed)

Created:
4 years, 4 months ago by Marc Treib
Modified:
4 years, 4 months ago
Reviewers:
kmadhusu
CC:
chromium-reviews, skanuj+watch_chromium.org, melevin+watch_chromium.org, dhollowa+watch_chromium.org, dougw+watch_chromium.org, donnd+watch_chromium.org, jfweitz+watch_chromium.org, David Black, samarth+watch_chromium.org, kmadhusu+watch_chromium.org, Jered
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Remove search::ShouldUseAltInstantURL and ShouldUseSearchPathForInstant Based on unused/abandoned field trials. BUG=627483 Committed: https://crrev.com/3e89046c82efaf8513328fb7cfae0bb7f3a813f9 Cr-Commit-Position: refs/heads/master@{#412197}

Patch Set 1 #

Patch Set 2 : tests #

Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -84 lines) Patch
M chrome/browser/search/search.h View 1 chunk +0 lines, -11 lines 0 comments Download
M chrome/browser/search/search.cc View 3 chunks +0 lines, -30 lines 0 comments Download
M chrome/browser/search/search_unittest.cc View 1 2 chunks +0 lines, -43 lines 0 comments Download

Messages

Total messages: 17 (11 generated)
Marc Treib
PTAL!
4 years, 4 months ago (2016-08-04 11:07:23 UTC) #2
Marc Treib
On 2016/08/04 11:07:23, Marc Treib wrote: > PTAL! Ping!
4 years, 4 months ago (2016-08-08 11:05:00 UTC) #11
kmadhusu
LGTM. Sorry for the delay. Thanks.
4 years, 4 months ago (2016-08-15 15:38:37 UTC) #12
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204363003/20001
4 years, 4 months ago (2016-08-16 08:27:16 UTC) #14
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-16 09:09:28 UTC) #15
commit-bot: I haz the power
4 years, 4 months ago (2016-08-16 09:11:46 UTC) #17
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/3e89046c82efaf8513328fb7cfae0bb7f3a813f9
Cr-Commit-Position: refs/heads/master@{#412197}

Powered by Google App Engine
This is Rietveld 408576698