content/renderer/categorized_worker_pool.cc - Issue 2204333003: Add joinable option to SimpleThread::Options as was just done for Thread.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: content/renderer/categorized_worker_pool.cc

Issue 2204333003: Add joinable option to SimpleThread::Options as was just done for Thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b1_nonjoinable_thread

Patch Set: Remove DCHECK => rely on ASAN/TSAN for early Delegate deletion Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: content/renderer/categorized_worker_pool.cc

diff --git a/content/renderer/categorized_worker_pool.cc b/content/renderer/categorized_worker_pool.cc

index 8250071c59f02db4cde763808b2e0c43ab52385b..47298b3b8ecd11ade943fabbcff164a0f925baf3 100644

--- a/content/renderer/categorized_worker_pool.cc

+++ b/content/renderer/categorized_worker_pool.cc

@@ -150,7 +150,7 @@ void CategorizedWorkerPool::Start(int num_threads) {

// Use background priority for background thread.

base::SimpleThread::Options thread_options;

#if !defined(OS_MACOSX)

- thread_options.set_priority(base::ThreadPriority::BACKGROUND);

+ thread_options.priority = base::ThreadPriority::BACKGROUND;

#endif

std::unique_ptr<base::SimpleThread> thread(new CategorizedWorkerPoolThread(

« base/threading/simple_thread.h ('K') | « base/threading/simple_thread_unittest.cc ('k') | no next file » | no next file with comments »