Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2856)

Unified Diff: base/threading/thread_restrictions.h

Issue 2204333003: Add joinable option to SimpleThread::Options as was just done for Thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b1_nonjoinable_thread
Patch Set: +friend for ScopedAllowWait.. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: base/threading/thread_restrictions.h
diff --git a/base/threading/thread_restrictions.h b/base/threading/thread_restrictions.h
index 30f787b1c4fc02d1436bd23b404c88f107739aca..d3fcb0c58a608228d294866d9071e0074d420662 100644
--- a/base/threading/thread_restrictions.h
+++ b/base/threading/thread_restrictions.h
@@ -9,6 +9,11 @@
#include "base/logging.h"
#include "base/macros.h"
+#if DCHECK_IS_ON()
jam 2016/08/10 17:34:36 tangent: it's odd that this is DCHECK_IS_ON() inst
jam 2016/08/10 17:35:18 nvm i see https://chromium.googlesource.com/chromi
+// For DelegateSimpleThread::Delegate.
+#include "base/threading/simple_thread.h"
+#endif
+
class BrowserProcessImpl;
class HistogramSynchronizer;
class NativeBackendKWallet;
@@ -209,6 +214,10 @@ class BASE_EXPORT ThreadRestrictions {
friend class ui::CommandBufferClientImpl;
friend class ui::CommandBufferLocal;
friend class ui::GpuState;
+ // Only required for DCHECK assertions.
+#if DCHECK_IS_ON()
+ friend class DelegateSimpleThread::Delegate;
+#endif
// END ALLOWED USAGE.
// BEGIN USAGE THAT NEEDS TO BE FIXED.

Powered by Google App Engine
This is Rietveld 408576698