Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(145)

Side by Side Diff: base/threading/thread_restrictions.h

Issue 2204333003: Add joinable option to SimpleThread::Options as was just done for Thread. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@b1_nonjoinable_thread
Patch Set: +friend for ScopedAllowWait.. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef BASE_THREADING_THREAD_RESTRICTIONS_H_ 5 #ifndef BASE_THREADING_THREAD_RESTRICTIONS_H_
6 #define BASE_THREADING_THREAD_RESTRICTIONS_H_ 6 #define BASE_THREADING_THREAD_RESTRICTIONS_H_
7 7
8 #include "base/base_export.h" 8 #include "base/base_export.h"
9 #include "base/logging.h" 9 #include "base/logging.h"
10 #include "base/macros.h" 10 #include "base/macros.h"
11 11
12 #if DCHECK_IS_ON()
jam 2016/08/10 17:34:36 tangent: it's odd that this is DCHECK_IS_ON() inst
jam 2016/08/10 17:35:18 nvm i see https://chromium.googlesource.com/chromi
13 // For DelegateSimpleThread::Delegate.
14 #include "base/threading/simple_thread.h"
15 #endif
16
12 class BrowserProcessImpl; 17 class BrowserProcessImpl;
13 class HistogramSynchronizer; 18 class HistogramSynchronizer;
14 class NativeBackendKWallet; 19 class NativeBackendKWallet;
15 class ScopedAllowWaitForLegacyWebViewApi; 20 class ScopedAllowWaitForLegacyWebViewApi;
16 21
17 namespace cc { 22 namespace cc {
18 class CompletionEvent; 23 class CompletionEvent;
19 class SingleThreadTaskGraphRunner; 24 class SingleThreadTaskGraphRunner;
20 } 25 }
21 namespace chromeos { 26 namespace chromeos {
(...skipping 180 matching lines...) Expand 10 before | Expand all | Expand 10 after
202 friend class SimpleThread; 207 friend class SimpleThread;
203 friend class Thread; 208 friend class Thread;
204 friend class ThreadTestHelper; 209 friend class ThreadTestHelper;
205 friend class PlatformThread; 210 friend class PlatformThread;
206 friend class android::JavaHandlerThread; 211 friend class android::JavaHandlerThread;
207 friend class mojo::common::MessagePumpMojo; 212 friend class mojo::common::MessagePumpMojo;
208 friend class mojo::SyncCallRestrictions; 213 friend class mojo::SyncCallRestrictions;
209 friend class ui::CommandBufferClientImpl; 214 friend class ui::CommandBufferClientImpl;
210 friend class ui::CommandBufferLocal; 215 friend class ui::CommandBufferLocal;
211 friend class ui::GpuState; 216 friend class ui::GpuState;
217 // Only required for DCHECK assertions.
218 #if DCHECK_IS_ON()
219 friend class DelegateSimpleThread::Delegate;
220 #endif
212 221
213 // END ALLOWED USAGE. 222 // END ALLOWED USAGE.
214 // BEGIN USAGE THAT NEEDS TO BE FIXED. 223 // BEGIN USAGE THAT NEEDS TO BE FIXED.
215 friend class ::chromeos::BlockingMethodCaller; // http://crbug.com/125360 224 friend class ::chromeos::BlockingMethodCaller; // http://crbug.com/125360
216 friend class ::chromeos::system::StatisticsProviderImpl; // http://crbug.com/ 125385 225 friend class ::chromeos::system::StatisticsProviderImpl; // http://crbug.com/ 125385
217 friend class chrome_browser_net::Predictor; // http://crbug.com/78451 226 friend class chrome_browser_net::Predictor; // http://crbug.com/78451
218 friend class 227 friend class
219 content::BrowserGpuChannelHostFactory; // http://crbug.com/125248 228 content::BrowserGpuChannelHostFactory; // http://crbug.com/125248
220 friend class 229 friend class
221 content::BrowserGpuMemoryBufferManager; // http://crbug.com/420368 230 content::BrowserGpuMemoryBufferManager; // http://crbug.com/420368
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
255 264
256 DISALLOW_COPY_AND_ASSIGN(ScopedAllowWait); 265 DISALLOW_COPY_AND_ASSIGN(ScopedAllowWait);
257 }; 266 };
258 267
259 DISALLOW_IMPLICIT_CONSTRUCTORS(ThreadRestrictions); 268 DISALLOW_IMPLICIT_CONSTRUCTORS(ThreadRestrictions);
260 }; 269 };
261 270
262 } // namespace base 271 } // namespace base
263 272
264 #endif // BASE_THREADING_THREAD_RESTRICTIONS_H_ 273 #endif // BASE_THREADING_THREAD_RESTRICTIONS_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698