Issue 22043002: Crash trying to render a SVGFEDistantLightElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 22043002: Crash trying to render a SVGFEDistantLightElement (Closed)

Created:
7 years, 4 months ago by do-not-use

Modified:
7 years, 4 months ago

Reviewers:
pdr., fmalita_google_do_not_use, inferno

CC:
blink-reviews, pdr, f(malita), dglazkov+blink, eae+blinkwatch, Stephen Chennney, lgombos

Base URL:
svn://svn.chromium.org/blink/trunk

Visibility:
Public.

Crash trying to render a SVGFEDistantLightElement Override rendererIsNeeded() in SVGFELightElement to return false so that we don't attempt to render such elements. This is a regression from r155426. TBR=pdr@chromium.org BUG=267824 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=155469

Created: 7 years, 4 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+12 lines, -2 lines)			Patch
M	LayoutTests/TestExpectations	View	1 chunk	+2 lines, -0 lines	0 comments	Download
A	LayoutTests/svg/filters/feDistantLight-rendering-crash.svg	View	1 chunk	+6 lines, -0 lines	0 comments	Download
A +	LayoutTests/svg/filters/feDistantLight-rendering-crash-expected.txt	View	1 chunk	+2 lines, -2 lines	0 comments	Download
M	Source/core/svg/SVGFELightElement.h	View	1 chunk	+2 lines, -0 lines	0 comments	Download

Total messages: 4 (0 generated)

commit-bot: I haz the power

CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@sisa.samsung.com/22043002/1

7 years, 4 months ago (2013-08-03 08:34:01 UTC) #2

do-not-use

Committed patchset #1 manually as r155469 (presubmit successful).

7 years, 4 months ago (2013-08-03 09:30:10 UTC) #3

pdr.

7 years, 4 months ago (2013-08-03 22:06:59 UTC) #4

Message was sent while issue was closed.

On 2013/08/03 09:30:10, Christophe Dumez wrote:
> Committed patchset #1 manually as r155469 (presubmit successful).

Belated LGTM