Issue 25666. Add test for shadowing of a superclass member from other library.

pkg/analysis_server/test/services/refactoring/rename_class_member_test.dart

 // Copyright (c) 2014, the Dart project authors.  Please see the AUTHORS file
 // for details. All rights reserved. Use of this source code is governed by a
 // BSD-style license that can be found in the LICENSE file.
 
 library test.services.refactoring.rename_class_member;
 
 import 'package:analysis_server/plugin/protocol/protocol.dart';
 import 'package:analysis_server/src/services/correction/status.dart';
+import 'package:analyzer/src/generated/source.dart';
 import 'package:test_reflective_loader/test_reflective_loader.dart';
 import 'package:unittest/unittest.dart';
 
 import '../../utils.dart';
 import 'abstract_rename.dart';
 
 main() {
   initializeTestEnvironment();
   defineReflectiveTests(RenameClassMemberTest);
 }
@@ skipping 239 matching lines @@
     createRenameRefactoringAtString('test() {}');
     // check status
     refactoring.newName = 'newName';
     RefactoringStatus status = await refactoring.checkFinalConditions();
     assertRefactoringStatus(status, RefactoringProblemSeverity.ERROR,
         expectedMessage:
             "Usage of renamed method will be shadowed by parameter 'newName'.",
         expectedContextSearch: 'test(); // marker');
   }
 
-  test_checkFinalConditions_shadowed_inSubClass() async {
+  test_checkFinalConditions_shadowedBySub_MethodElement() async {
     indexTestUnit('''
 class A {
-  newName() {} // marker
+  test() {}
 }
 class B extends A {
-  test() {}
+  newName() {} // marker
   main() {
-    newName();
+    test();
   }
 }
 ''');
     createRenameRefactoringAtString('test() {}');
     // check status
     refactoring.newName = 'newName';
     RefactoringStatus status = await refactoring.checkFinalConditions();
     assertRefactoringStatus(status, RefactoringProblemSeverity.ERROR,
-        expectedMessage: "Renamed method will shadow method 'A.newName'.",
+        expectedMessage:
+            "Renamed method will be shadowed by method 'B.newName'.",
         expectedContextSearch: 'newName() {} // marker');
   }
 
-  test_checkFinalConditions_shadowsSuper_inSubClass_FieldElement() async {
+  test_checkFinalConditions_shadowsSuper_FieldElement() async {
     indexTestUnit('''
 class A {
   int newName; // marker
 }
 class B extends A {
   test() {}
 }
 class C extends B {
   main() {
     print(newName);
   }
 }
 ''');
     createRenameRefactoringAtString('test() {}');
     // check status
     refactoring.newName = 'newName';
     RefactoringStatus status = await refactoring.checkFinalConditions();
     assertRefactoringStatus(status, RefactoringProblemSeverity.ERROR,
         expectedMessage: "Renamed method will shadow field 'A.newName'.",
         expectedContextSearch: 'newName; // marker');
   }
 
   test_checkFinalConditions_shadowsSuper_MethodElement() async {
     indexTestUnit('''
 class A {
-  test() {}
+  newName() {} // marker
 }
 class B extends A {
-  newName() {} // marker
-  main() {
-    test();
-  }
+  test() {}
 }
 ''');
     createRenameRefactoringAtString('test() {}');
     // check status
     refactoring.newName = 'newName';
     RefactoringStatus status = await refactoring.checkFinalConditions();
     assertRefactoringStatus(status, RefactoringProblemSeverity.ERROR,
-        expectedMessage:
-            "Renamed method will be shadowed by method 'B.newName'.",
+        expectedMessage: "Renamed method will shadow method 'A.newName'.",
         expectedContextSearch: 'newName() {} // marker');
   }
 
+  test_checkFinalConditions_shadowsSuper_MethodElement_otherLib() async {
+    var libCode = r'''
+class A {
+  newName() {} // marker
+}
+''';
+    indexUnit('/lib.dart', libCode);
+    indexTestUnit('''
+import 'lib.dart';
+class B extends A {
+  test() {}
+}
+''');
+    createRenameRefactoringAtString('test() {}');
+    // check status
+    refactoring.newName = 'newName';
+    RefactoringStatus status = await refactoring.checkFinalConditions();
+    assertRefactoringStatus(status, RefactoringProblemSeverity.ERROR,
+        expectedMessage: "Renamed method will shadow method 'A.newName'.",
+        expectedContextRange: new SourceRange(
+            libCode.indexOf('newName() {} // marker'), 'newName'.length));
+  }
+
   test_checkInitialConditions_inSDK() async {
     indexTestUnit('''
 main() {
   'abc'.toUpperCase();
 }
 ''');
     createRenameRefactoringAtString('toUpperCase()');
     // check status
     refactoring.newName = 'NewName';
     RefactoringStatus status = await refactoring.checkInitialConditions();
@@ skipping 528 matching lines @@
     // validate change
     return assertSuccessfulRefactoring('''
 class A<NewName> {
   NewName field;
   List<NewName> items;
   NewName method(NewName p) => null;
 }
 ''');
   }
 }