Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1220)

Unified Diff: test/cctest/test-api.cc

Issue 2204243003: [Interpreter] Avoid dereferencing handles in ConstantPoolArrayBuilder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master
Patch Set: Address comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: test/cctest/test-api.cc
diff --git a/test/cctest/test-api.cc b/test/cctest/test-api.cc
index 6c21c7cea157e6b1f9bcd1c4baeeb6ee2853dbc6..2430cbef5d02d0b9e2d25a7651adf326d390ddd8 100644
--- a/test/cctest/test-api.cc
+++ b/test/cctest/test-api.cc
@@ -23940,7 +23940,6 @@ void RunStreamingTest(const char** chunks,
delete[] full_source;
}
-
TEST(StreamingSimpleScript) {
// This script is unrealistically small, since no one chunk is enough to fill
// the backing buffer of Scanner, let alone overflow it.
@@ -23949,6 +23948,17 @@ TEST(StreamingSimpleScript) {
RunStreamingTest(chunks);
}
+TEST(StreamingScriptConstantArray) {
+ // When run with Ignition, tests that the streaming parser canonicalizes
+ // handles so that they are only added to the constant pool array once.
+ const char* chunks[] = {"var a = {};",
+ "var b = {};",
+ "var c = 'testing';",
+ "var d = 'testing';",
+ "13;",
+ NULL};
+ RunStreamingTest(chunks);
+}
TEST(StreamingBiggerScript) {
const char* chunk1 =
« no previous file with comments | « test/cctest/interpreter/test-interpreter.cc ('k') | test/unittests/interpreter/bytecode-array-builder-unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698