test/unittests/interpreter/bytecode-array-builder-unittest.cc - Issue 2204243003: [Interpreter] Avoid dereferencing handles in ConstantPoolArrayBuilder.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: test/unittests/interpreter/bytecode-array-builder-unittest.cc

Issue 2204243003: [Interpreter] Avoid dereferencing handles in ConstantPoolArrayBuilder. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@master

Patch Set: Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « test/cctest/test-api.cc ('k') | test/unittests/interpreter/constant-array-builder-unittest.cc » ('j') | test/unittests/interpreter/constant-array-builder-unittest.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: test/unittests/interpreter/bytecode-array-builder-unittest.cc

diff --git a/test/unittests/interpreter/bytecode-array-builder-unittest.cc b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

index 5c6a713c4f2fa4ee53b042785c5ec8af66272e4b..59fe92a93cb0dd1c340b22e88813a474d6a31153 100644

--- a/test/unittests/interpreter/bytecode-array-builder-unittest.cc

+++ b/test/unittests/interpreter/bytecode-array-builder-unittest.cc

@@ -515,6 +515,7 @@ TEST_F(BytecodeArrayBuilderTest, RegisterType) {

TEST_F(BytecodeArrayBuilderTest, Constants) {

BytecodeArrayBuilder builder(isolate(), zone(), 0, 0, 0);

+ CanonicalHandleScope canonical(isolate());

Factory* factory = isolate()->factory();

Handle<HeapObject> heap_num_1 = factory->NewHeapNumber(3.14);