Blimp OAuth2 token retreival on application start up.

blimp/client/core/session/identity_source_unittest.cc

Index: blimp/client/core/session/identity_source_unittest.cc
diff --git a/blimp/client/core/session/identity_source_unittest.cc b/blimp/client/core/session/identity_source_unittest.cc
new file mode 100644
index 0000000000000000000000000000000000000000..29a16f727439e84f9be1ae5e32fef884d962b0f5
--- /dev/null
+++ b/blimp/client/core/session/identity_source_unittest.cc
@@ -0,0 +1,142 @@
+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#include "blimp/client/core/session/identity_source.h"
+
+#include "base/macros.h"
+#include "base/memory/ptr_util.h"
+#include "blimp/client/test/test_blimp_client_context_delegate.h"
+#include "google_apis/gaia/fake_identity_provider.h"
+#include "google_apis/gaia/fake_oauth2_token_service.h"
+#include "google_apis/gaia/google_service_auth_error.h"
+#include "testing/gmock/include/gmock/gmock.h"

[nyquist, 2016/08/12 05:47:04]

Is this used here?

[xingliu, 2016/08/12 17:58:27]

Done.

+#include "testing/gtest/include/gtest/gtest.h"
+
+namespace blimp {
+namespace client {
+namespace {
+
+class IdentitySourceTest : public testing::Test {
+ public:
+  class MockIdentitySource : public IdentitySource {

[nyquist, 2016/08/12 05:47:04]

Does this need to be an inner class, or could you just declare it above
IdentitySourceTest?

[xingliu, 2016/08/12 17:58:27]

Done.

+   public:
+    explicit MockIdentitySource(
+        std::unique_ptr<IdentityProvider> identity_provider)
+        : IdentitySource(std::move(identity_provider)),
+          success_(0),
+          fail_(0),
+          refresh_(0) {}
+    ~MockIdentitySource() override{};
+
+    void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
+                           const std::string& access_token,
+                           const base::Time& expiration_time) override {
+      IdentitySource::OnGetTokenSuccess(request, access_token, expiration_time);
+      success_++;
+      token_ = access_token;
+    }
+
+    void OnGetTokenFailure(const OAuth2TokenService::Request* request,
+                           const GoogleServiceAuthError& error) override {
+      IdentitySource::OnGetTokenFailure(request, error);
+      fail_++;
+      token_.clear();
+    }
+
+    void OnRefreshTokenAvailable(const std::string& account_id) override {
+      IdentitySource::OnRefreshTokenAvailable(account_id);
+      refresh_++;
+    }
+
+    int Succeeded() { return success_; }
+    int Failed() { return fail_; }
+    int Refreshed() { return refresh_; }
+    const std::string& Token() { return token_; }
+
+   private:

[nyquist, 2016/08/12 05:47:04]

DISALLOW_COPY_AND_ASSIGN?

[xingliu, 2016/08/12 17:58:27]

Done.

+    std::string token_;
+    int success_;
+    int fail_;
+    int refresh_;
+  };
+
+  IdentitySourceTest() {}

[nyquist, 2016/08/12 05:47:04]

= default here and below?

[xingliu, 2016/08/12 17:58:28]

Done.

+  ~IdentitySourceTest() override {}
+
+ private:
+  DISALLOW_COPY_AND_ASSIGN(IdentitySourceTest);
+};
+
+TEST_F(IdentitySourceTest, TestConnect) {
+  std::unique_ptr<FakeOAuth2TokenService> token_service =
+      base::MakeUnique<FakeOAuth2TokenService>();
+  FakeIdentityProvider* id_provider =
+      new FakeIdentityProvider(token_service.get());
+  std::unique_ptr<IdentityProvider> id_ptr =
+      base::WrapUnique<IdentityProvider>((IdentityProvider*)id_provider);
+
+  MockIdentitySource auth(std::move(id_ptr));
+  TestBlimpClientContextDelegate mock_blimp_delegate;
+  auth.SetDelegate(&mock_blimp_delegate);
+
+  // Connect when user is not signed in. Nothing happens.
+  id_provider->LogOut();
+  auth.Connect();
+  DCHECK_EQ(auth.Succeeded(), 0);
+  DCHECK_EQ(auth.Failed(), 0);
+  DCHECK_EQ(auth.Refreshed(), 0);
+  DCHECK_EQ(auth.Token(), std::string());
+
+  FakeOAuth2TokenServiceDelegate* mock_delegate =

[nyquist, 2016/08/12 05:47:04]

Could you make this name a little bit more specific, especially since there are
multiple delegates in play here.

[xingliu, 2016/08/12 17:58:27]

Done.

+      token_service->GetFakeOAuth2TokenServiceDelegate();
+
+  // Connect when user signed in, but no refresh token, refresh token observer
+  // should be added.
+  std::string account = "mock_account";
+  id_provider->LogIn(account);
+  mock_delegate->RevokeCredentials(account);
+  auth.Connect();
+  DCHECK_EQ(auth.Succeeded(), 0);
+  DCHECK_EQ(auth.Failed(), 0);
+  DCHECK_EQ(auth.Refreshed(), 0);
+
+  // Issue refresh token, listener should be triggered, and request should be
+  // sent.
+  mock_delegate->UpdateCredentials(account, "mock_refresh_token");
+  DCHECK_EQ(auth.Succeeded(), 0);
+  DCHECK_EQ(auth.Failed(), 0);
+  DCHECK_EQ(auth.Refreshed(), 1);
+
+  // Fire access token success, first request should be fulfilled.
+  base::Time time;
+  std::string mock_access_token = "mock_access_token";
+  token_service->IssueAllTokensForAccount(account, mock_access_token, time);
+  DCHECK_EQ(auth.Succeeded(), 1);
+  DCHECK_EQ(auth.Failed(), 0);
+  DCHECK_EQ(auth.Token(), mock_access_token);
+
+  // Connect again and fire access token failed.
+  GoogleServiceAuthError error(GoogleServiceAuthError::State::REQUEST_CANCELED);
+  auth.Connect();
+  token_service->IssueErrorForAllPendingRequestsForAccount(account, error);
+  DCHECK_EQ(auth.Succeeded(), 1);
+  DCHECK_EQ(auth.Failed(), 1);
+  DCHECK_EQ(auth.Token(), std::string());
+
+  // Refresh token listener should have been removed.
+  mock_delegate->UpdateCredentials(account, "mock_refresh_token");
+  DCHECK_EQ(auth.Refreshed(), 1);
+
+  // Direct connect with refresh token, and no listener should be added.
+  auth.Connect();
+  token_service->IssueAllTokensForAccount(account, mock_access_token, time);
+  DCHECK_EQ(auth.Succeeded(), 2);
+  DCHECK_EQ(auth.Token(), mock_access_token);
+  mock_delegate->UpdateCredentials(account, "mock_refresh_token");
+  DCHECK_EQ(auth.Refreshed(), 1);
+}
+
+}  // namespace
+}  // namespace client
+}  // namespace blimp