blimp/client/core/dummy_blimp_client_context.cc - Issue 2204223005: Blimp OAuth2 token retreival on application start up.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: blimp/client/core/dummy_blimp_client_context.cc

Issue 2204223005: Blimp OAuth2 token retreival on application start up. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add some deps only for gn deps check script. Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« blimp/client/core/blimp_client_context_impl.cc ('K') | « blimp/client/core/dummy_blimp_client_context.h ('k') | blimp/client/core/session/BUILD.gn » ('j') | blimp/client/core/session/identity_source.cc » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: blimp/client/core/dummy_blimp_client_context.cc

diff --git a/blimp/client/core/dummy_blimp_client_context.cc b/blimp/client/core/dummy_blimp_client_context.cc

index 8c0f2508a1fab292f3d3edcdf00e9702066e2c9f..30629fb5ea6692351672d583f8cf933f64dab167 100644

--- a/blimp/client/core/dummy_blimp_client_context.cc

+++ b/blimp/client/core/dummy_blimp_client_context.cc

@@ -45,5 +45,7 @@ void DummyBlimpClientContext::Connect(const std::string& client_auth_token) {

NOTREACHED();

}

+void DummyBlimpClientContext::Connect() {}

nyquist 2016/08/12 05:47:04 Do we want to add NOTREACHED() here as well, to en

xingliu 2016/08/12 21:11:18 Done.

} // namespace client

} // namespace blimp