Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(3702)

Unified Diff: blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java

Issue 2204223005: Blimp OAuth2 token retreival on application start up. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Add deps file. Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java
diff --git a/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java b/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java
index f59b479619bd79dc38bbb744bcc170ad5bbcec58..6b7608e862919856aa905ffe3b7b5a8c9023a243 100644
--- a/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java
+++ b/blimp/client/public/android/java/src/org/chromium/blimp_public/BlimpClientContext.java
@@ -39,4 +39,15 @@ public interface BlimpClientContext {
* Java Blimp code only.
*/
void setDelegate(BlimpClientContextDelegate delegate);
+
+ /**
+ * Connect to Blimp engine.
+ * @param clientToken OAuth2 token.
+ */
+ void connect(String clientToken);
David Trainor- moved to gerrit 2016/08/05 15:49:09 Should this be exposed in the public interface? W
xingliu 2016/08/05 17:17:00 I think that's better, will discuss it with Tommy.
xingliu 2016/08/09 04:17:45 Done. Now token is handled in c++. No exposure in
+
+ /**
+ * Get OAuth2 token for Blimp.
+ */
+ void getAuthToken();
David Trainor- moved to gerrit 2016/08/05 15:49:09 Shouldn't the publicly exposed method just be conn
xingliu 2016/08/05 17:17:00 Oh, this function is probably badly named, what it
xingliu 2016/08/09 04:17:45 Removed.
}

Powered by Google App Engine
This is Rietveld 408576698