Blimp OAuth2 token retreival on application start up.

blimp/client/core/authenticator.h

+// Copyright 2016 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef BLIMP_CLIENT_CORE_AUTHENTICATOR_H_
+#define BLIMP_CLIENT_CORE_AUTHENTICATOR_H_
+
+#include "base/macros.h"
+
+#include "google_apis/gaia/identity_provider.h"
+#include "google_apis/gaia/oauth2_token_service.h"
+
+namespace blimp {
+namespace client {
+
+// Authenticator handles OAuth2 token request and forward user sign in state

[nyquist, 2016/08/10 16:48:56]

Could we come up with a different name than 'Authenticator' that's even more
descriptive? I'm not sure what's a good name yet, but Authenticator has a very
specific purpose in the Android platform. See
https://developer.android.com/training/sync-adapters/creating-authenticator.html

[xingliu, 2016/08/10 21:03:14]

Renamed to IdentitySource, also Authenticator is probably too general for this
class.

+// change to Blimp with ProfileIdentityProvider.
+class Authenticator : public OAuth2TokenService::Consumer,

[nyquist, 2016/08/10 01:20:33]

I think we want this to live in //blimp/client/core/session

[xingliu, 2016/08/10 21:03:14]

Done.

+                      public OAuth2TokenService::Observer,
+                      public IdentityProvider::Observer {
+ public:
+  explicit Authenticator(
+      std::unique_ptr<IdentityProvider> identity_provider);
+
+  ~Authenticator() override;
+
+  // Start Blimp authentication by requesting OAuth2 token from google.

[nyquist, 2016/08/10 01:20:33]

Capitalize Google here and below.

[xingliu, 2016/08/10 21:03:14]

Done.

+  void Connect();
+
+  // OAuth2TokenService::Consumer implementation.
+  void OnGetTokenSuccess(const OAuth2TokenService::Request* request,
+                         const std::string& access_token,
+                         const base::Time& expiration_time) override;
+  void OnGetTokenFailure(const OAuth2TokenService::Request* request,
+                         const GoogleServiceAuthError& error) override;
+
+  // OAuth2TokenService::Observer implementation.
+  void OnRefreshTokenAvailable(const std::string& account_id) override;
+
+  // IdentityProvider::Observer implementation.
+  void OnActiveAccountLogin() override;
+  void OnActiveAccountLogout() override;
+
+ private:
+  // Fetch OAuth token.
+  void FetchAuthToken();
+
+  // Provide OAuth2 token service and listen to google account sign in state.
+  std::unique_ptr<IdentityProvider> identity_provider_;

[nyquist, 2016/08/10 01:20:33]

#include <memory>

[xingliu, 2016/08/10 21:03:14]

Done.

+
+  // OAuth2 token request. This class should take ownership of the request.

[nyquist, 2016/08/10 01:20:33]

std::unique_ptr implies ownership. Maybe instead focus on when it's created and
for how long it lives? Is this for the one in-flight?

[xingliu, 2016/08/10 21:03:14]

I'll change the comment.

Yes, it's the actual request on the fly.

+  std::unique_ptr<OAuth2TokenService::Request> token_request_;
+
+  // Account id of current active user, used during token request.
+  std::string account_id_;

[nyquist, 2016/08/10 01:20:33]

#include <string>

[xingliu, 2016/08/10 21:03:14]

Done.

+
+  DISALLOW_COPY_AND_ASSIGN(Authenticator);
+};
+
+}  // namespace client
+}  // namespace blimp
+
+#endif  // BLIMP_CLIENT_CORE_AUTHENTICATOR_H_