Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(433)

Unified Diff: third_party/WebKit/Source/web/CompositorProxyClientImpl.h

Issue 2204183002: Prepare CompositorWorker for per thread heap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: fix Created 4 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/web/CompositorProxyClientImpl.h
diff --git a/third_party/WebKit/Source/web/CompositorProxyClientImpl.h b/third_party/WebKit/Source/web/CompositorProxyClientImpl.h
index 3390c4a965356cfb6abb1ee876835b7fa999ae44..e3fb0582b092ea228d11107563f5b26be5e9ebd3 100644
--- a/third_party/WebKit/Source/web/CompositorProxyClientImpl.h
+++ b/third_party/WebKit/Source/web/CompositorProxyClientImpl.h
@@ -21,7 +21,7 @@ class WorkerGlobalScope;
// mutator, e.g. if a single document creates multiple CompositorWorker objects.
//
// Should be accessed only on the compositor thread.
-class CompositorProxyClientImpl final : public GarbageCollected<CompositorProxyClientImpl>, public CompositorProxyClient {
+class CompositorProxyClientImpl final : public GarbageCollectedFinalized<CompositorProxyClientImpl>, public CompositorProxyClient {
USING_GARBAGE_COLLECTED_MIXIN(CompositorProxyClientImpl);
WTF_MAKE_NONCOPYABLE(CompositorProxyClientImpl);
public:
@@ -41,9 +41,9 @@ public:
private:
bool executeAnimationFrameCallbacks(double monotonicTimeNow);
- Member<CompositorMutatorImpl> m_mutator;
+ CrossThreadPersistent<CompositorMutatorImpl> m_mutator;
- Member<CompositorWorkerGlobalScope> m_globalScope;
+ CrossThreadWeakPersistent<CompositorWorkerGlobalScope> m_globalScope;
keishi 2016/09/02 06:41:55 CompositorProxyClientImpl::m_globalScope was causi
bool m_requestedAnimationFrameCallbacks;
HeapHashSet<WeakMember<CompositorProxy>> m_proxies;

Powered by Google App Engine
This is Rietveld 408576698