third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h - Issue 2204183002: Prepare CompositorWorker for per thread heap

Unified Diff: third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h

Issue 2204183002: Prepare CompositorWorker for per thread heap (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: fix Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/LayoutTests/virtual/threaded/fast/compositorworker/compositor-proxy-disconnect-worker-terminate.html ('K') | « third_party/WebKit/Source/core/dom/CompositorProxy.h ('k') | third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp » ('j') | third_party/WebKit/Source/core/workers/WorkerBackingThread.cpp » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h

diff --git a/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h b/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h

index d7213448bc955595bcb27967e6283ccf6fbcd12c..3950307d99c09605870ce856fd23665eab0be891 100644

--- a/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h

+++ b/third_party/WebKit/Source/core/workers/InProcessWorkerObjectProxy.h

@@ -108,7 +108,7 @@ private:

// but made as a member variable for testing.

double m_maxIntervalInSec;

- Persistent<WorkerGlobalScope> m_workerGlobalScope;

+ CrossThreadPersistent<WorkerGlobalScope> m_workerGlobalScope;

haraken 2016/08/22 14:24:43 I want to make sure that these CrossThreadPersiste

keishi 2016/09/02 06:41:55 - Added the WorkerGlobalScope leak detector. r4149

haraken 2016/09/02 09:39:17 Nice detective work! Posted some ideas on https://

};

} // namespace blink