Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(203)

Issue 2204133002: Bring heap snapshot Map iterator up to date. (Closed)

Created:
4 years, 4 months ago by alph
Modified:
4 years, 4 months ago
Reviewers:
ulan
CC:
v8-reviews_googlegroups.com
Base URL:
https://chromium.googlesource.com/v8/v8.git@master
Target Ref:
refs/pending/heads/master
Project:
v8
Visibility:
Public.

Description

Bring heap snapshot Map iterator up to date. 1. Do not mark code_cache as a weak container. 2. Support layout_descriptor field. Committed: https://crrev.com/b123476bcb5a60bae26627d1358ceea8f04bc686 Cr-Commit-Position: refs/heads/master@{#38285}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+17 lines, -15 lines) Patch
M src/objects.h View 1 chunk +3 lines, -3 lines 0 comments Download
M src/objects-inl.h View 2 chunks +3 lines, -4 lines 0 comments Download
M src/profiler/heap-snapshot-generator.cc View 1 chunk +11 lines, -8 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
alph
4 years, 4 months ago (2016-08-03 10:06:23 UTC) #2
ulan
lgtm
4 years, 4 months ago (2016-08-03 10:26:43 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2204133002/1
4 years, 4 months ago (2016-08-03 10:58:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 11:00:15 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 11:02:07 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/b123476bcb5a60bae26627d1358ceea8f04bc686
Cr-Commit-Position: refs/heads/master@{#38285}

Powered by Google App Engine
This is Rietveld 408576698