Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1297)

Unified Diff: cc/playback/display_item_list.cc

Issue 2204053003: Don't clear visual rects when finalizing display item lists for now. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: cc/playback/display_item_list.cc
diff --git a/cc/playback/display_item_list.cc b/cc/playback/display_item_list.cc
index 32cba8c984e4aa8b8dcbe8b93fdea65387f06e73..ea4c086371195207ed92f00dd16b0d6a79546adc 100644
--- a/cc/playback/display_item_list.cc
+++ b/cc/playback/display_item_list.cc
@@ -156,10 +156,12 @@ void DisplayItemList::Finalize() {
<< inputs_.visual_rects.size();
rtree_.Build(inputs_.visual_rects);
- if (!retain_visual_rects_)
- // This clears both the vector and the vector's capacity, since
- // visual_rects won't be used anymore.
- std::vector<gfx::Rect>().swap(inputs_.visual_rects);
+ // TODO(wkorman): Restore the below, potentially with a switch to allow
+ // clearing visual rects except for Blimp engine. http://crbug.com/633750
+ // if (!retain_visual_rects_)
Khushal 2016/08/03 00:29:05 We don't really need to do any post processing on
wkorman 2016/08/03 00:37:00 Yes, I wanted to do things more cleanly in a separ
Khushal 2016/08/03 00:44:42 Sorry for being unclear. I was suggesting that you
+ // // This clears both the vector and the vector's capacity, since
+ // // visual_rects won't be used anymore.
+ // std::vector<gfx::Rect>().swap(inputs_.visual_rects);
}
bool DisplayItemList::IsSuitableForGpuRasterization() const {
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698