Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Issue 220403012: Go directly to dialog instead of just the section when user requsts creating a new profile. (Closed)

Created:
6 years, 8 months ago by bcwhite
Modified:
6 years, 8 months ago
CC:
chromium-reviews, tim+watch_chromium.org, haitaol+watch_chromium.org, maniscalco+watch_chromium.org
Visibility:
Public.

Description

Go directly to dialog instead of just the section when user requsts creating a new profile. The current mechanism of "searching" for the Users section fails on non-English installs because search operates in the user's language while we're hard-coding a search for "Users". BUG=280919 Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=261453

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+1 line, -1 line) Patch
M chrome/browser/ui/sync/one_click_signin_helper.cc View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 13 (0 generated)
bcwhite
6 years, 8 months ago (2014-04-02 15:17:43 UTC) #1
Roger Tawa OOO till Jul 10th
lgtm Lets keep the bug open to track direct creation of profile.
6 years, 8 months ago (2014-04-02 15:23:57 UTC) #2
bcwhite
The CQ bit was checked by bcwhite@chromium.org
6 years, 8 months ago (2014-04-02 15:48:32 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/220403012/1
6 years, 8 months ago (2014-04-02 15:48:34 UTC) #4
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 21:36:59 UTC) #5
commit-bot: I haz the power
Retried try job too often on android_aosp for step(s) compile http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=android_aosp&number=60552
6 years, 8 months ago (2014-04-02 21:36:59 UTC) #6
bcwhite
The CQ bit was checked by bcwhite@chromium.org
6 years, 8 months ago (2014-04-03 12:38:49 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/220403012/1
6 years, 8 months ago (2014-04-03 12:39:12 UTC) #8
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-03 13:56:52 UTC) #9
commit-bot: I haz the power
Retried try job too often on win_rel for step(s) net_unittests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_rel&number=293237
6 years, 8 months ago (2014-04-03 13:56:53 UTC) #10
bcwhite
The CQ bit was checked by bcwhite@chromium.org
6 years, 8 months ago (2014-04-03 15:36:38 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bcwhite@chromium.org/220403012/1
6 years, 8 months ago (2014-04-03 15:38:39 UTC) #12
commit-bot: I haz the power
6 years, 8 months ago (2014-04-03 17:04:25 UTC) #13
Message was sent while issue was closed.
Change committed as 261453

Powered by Google App Engine
This is Rietveld 408576698