Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(714)

Issue 220403009: MIPS: Consistently use a separate Lithium instruction for flooring division. (Closed)

Created:
6 years, 8 months ago by palfia
Modified:
6 years, 8 months ago
CC:
v8-dev
Visibility:
Public.

Description

MIPS: Consistently use a separate Lithium instruction for flooring division. Port r20395 (5b802048) Original commit message: Previously we tried to share some code on by a slightly confusing re-use of LDivI for a (general) flooring division. Now we cleanly separate concerns, just like for the rest of the division-like operations. Note that ARM64 already did it this way. If we really want to save some code, we can introduce some macro assembler instructions and/or helper functions in the code generator in a future CL, but we should really try to avoid being "clever" to save just a few lines of trivial code. Effort != complexity. :-) Renamed some related Lithium operands on the way for more consistency. BUG= R=plind44@gmail.com Committed: https://code.google.com/p/v8/source/detail?r=20417

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+92 lines, -28 lines) Patch
M src/mips/lithium-codegen-mips.cc View 3 chunks +56 lines, -20 lines 0 comments Download
M src/mips/lithium-mips.h View 4 chunks +23 lines, -6 lines 0 comments Download
M src/mips/lithium-mips.cc View 2 chunks +13 lines, -2 lines 0 comments Download

Messages

Total messages: 3 (0 generated)
palfia
PTAL.
6 years, 8 months ago (2014-04-01 22:53:32 UTC) #1
Paul Lind
LGTM.
6 years, 8 months ago (2014-04-01 23:37:39 UTC) #2
palfia
6 years, 8 months ago (2014-04-01 23:43:56 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as r20417 (presubmit successful).

Powered by Google App Engine
This is Rietveld 408576698