Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(29)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 220403005: DevTools: synchronize links in StylesSidebarPane on edits. (Closed)

Created:
6 years, 8 months ago by lushnikov
Modified:
6 years, 8 months ago
Reviewers:
apavlov, pfeldman
CC:
blink-reviews, caseq+blink_chromium.org, loislo+blink_chromium.org, eustas+blink_chromium.org, alph+blink_chromium.org, yurys+blink_chromium.org, lushnikov+blink_chromium.org, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, paulirish+reviews_chromium.org, apavlov+blink_chromium.org, devtools-reviews_chromium.org, aandrey+blink_chromium.org
Visibility:
Public.

Description

DevTools: synchronize links in StylesSidebarPane on edits. This patch keeps all ranges in CSSRules up-to-date after setPropertyText/setRuleSelector methods gets called. It also updates links in stylesidebarpane sections titles. Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=170684

Patch Set 1 #

Patch Set 2 : add testcase #

Patch Set 3 : fix tests #

Total comments: 6

Patch Set 4 : address @apavlov comments #

Patch Set 5 : move events order #

Patch Set 6 : fix setDisabled case #

Total comments: 4

Patch Set 7 : extract common parts into _applyNewStyle method #

Unified diffs Side-by-side diffs Delta from patch set Stats (+597 lines, -61 lines) Patch
M LayoutTests/http/tests/inspector/elements-test.js View 1 chunk +5 lines, -1 line 0 comments Download
A LayoutTests/inspector/elements/styles/resources/styles-update-links.css View 1 2 3 4 5 6 1 chunk +14 lines, -0 lines 0 comments Download
A LayoutTests/inspector/elements/styles/styles-update-links.html View 1 2 3 4 5 1 chunk +184 lines, -0 lines 0 comments Download
A LayoutTests/inspector/elements/styles/styles-update-links-expected.txt View 1 2 3 4 5 6 1 chunk +179 lines, -0 lines 0 comments Download
M Source/devtools/front_end/CSSStyleModel.js View 1 2 3 7 chunks +71 lines, -2 lines 0 comments Download
M Source/devtools/front_end/StylesSidebarPane.js View 1 2 3 4 5 6 8 chunks +111 lines, -58 lines 0 comments Download
M Source/devtools/front_end/TextRange.js View 2 chunks +33 lines, -0 lines 0 comments Download

Messages

Total messages: 21 (0 generated)
lushnikov
Please, take a look
6 years, 8 months ago (2014-04-02 14:57:59 UTC) #1
apavlov
https://codereview.chromium.org/220403005/diff/40001/LayoutTests/inspector/elements/styles/styles-update-links-expected.txt File LayoutTests/inspector/elements/styles/styles-update-links-expected.txt (right): https://codereview.chromium.org/220403005/diff/40001/LayoutTests/inspector/elements/styles/styles-update-links-expected.txt#newcode39 LayoutTests/inspector/elements/styles/styles-update-links-expected.txt:39: #### AFTER PROPERTY INSERTION #### Please use InspectorTest.runTestSuite() to ...
6 years, 8 months ago (2014-04-02 15:23:56 UTC) #2
lushnikov
Thanks! https://codereview.chromium.org/220403005/diff/40001/LayoutTests/inspector/elements/styles/styles-update-links-expected.txt File LayoutTests/inspector/elements/styles/styles-update-links-expected.txt (right): https://codereview.chromium.org/220403005/diff/40001/LayoutTests/inspector/elements/styles/styles-update-links-expected.txt#newcode39 LayoutTests/inspector/elements/styles/styles-update-links-expected.txt:39: #### AFTER PROPERTY INSERTION #### On 2014/04/02 15:23:57, ...
6 years, 8 months ago (2014-04-02 15:35:03 UTC) #3
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 8 months ago (2014-04-02 15:35:09 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/220403005/60001
6 years, 8 months ago (2014-04-02 15:35:15 UTC) #5
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 15:35:16 UTC) #6
commit-bot: I haz the power
No LGTM from a valid reviewer yet. Only full committers are accepted. Even if an ...
6 years, 8 months ago (2014-04-02 15:35:16 UTC) #7
apavlov
lgtm
6 years, 8 months ago (2014-04-02 15:45:21 UTC) #8
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 8 months ago (2014-04-02 15:45:34 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/220403005/80001
6 years, 8 months ago (2014-04-02 15:45:38 UTC) #10
lushnikov
The CQ bit was unchecked by lushnikov@chromium.org
6 years, 8 months ago (2014-04-02 16:08:06 UTC) #11
apavlov
lgtm https://codereview.chromium.org/220403005/diff/100001/LayoutTests/inspector/elements/styles/styles-update-links-expected.txt File LayoutTests/inspector/elements/styles/styles-update-links-expected.txt (right): https://codereview.chromium.org/220403005/diff/100001/LayoutTests/inspector/elements/styles/styles-update-links-expected.txt#newcode53 LayoutTests/inspector/elements/styles/styles-update-links-expected.txt:53: /-- overloaded --/ display: relative; position: relative https://codereview.chromium.org/220403005/diff/100001/Source/devtools/front_end/StylesSidebarPane.js ...
6 years, 8 months ago (2014-04-02 16:43:47 UTC) #12
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 8 months ago (2014-04-02 16:52:31 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/220403005/110001
6 years, 8 months ago (2014-04-02 16:52:41 UTC) #14
lushnikov
https://codereview.chromium.org/220403005/diff/100001/LayoutTests/inspector/elements/styles/styles-update-links-expected.txt File LayoutTests/inspector/elements/styles/styles-update-links-expected.txt (right): https://codereview.chromium.org/220403005/diff/100001/LayoutTests/inspector/elements/styles/styles-update-links-expected.txt#newcode53 LayoutTests/inspector/elements/styles/styles-update-links-expected.txt:53: /-- overloaded --/ display: relative; On 2014/04/02 16:43:47, apavlov ...
6 years, 8 months ago (2014-04-02 16:53:01 UTC) #15
lushnikov
6 years, 8 months ago (2014-04-02 16:53:02 UTC) #16
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 8 months ago (2014-04-02 17:24:29 UTC) #17
commit-bot: I haz the power
Try jobs failed on following builders: tryserver.blink on win_blink_compile_dbg
6 years, 8 months ago (2014-04-02 17:24:29 UTC) #18
lushnikov
The CQ bit was checked by lushnikov@chromium.org
6 years, 8 months ago (2014-04-02 18:57:26 UTC) #19
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/lushnikov@chromium.org/220403005/110001
6 years, 8 months ago (2014-04-02 18:57:36 UTC) #20
commit-bot: I haz the power
6 years, 8 months ago (2014-04-02 19:28:48 UTC) #21
Message was sent while issue was closed. 
Change committed as 170684

Powered by Google App Engine
This is Rietveld 408576698