Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1086)

Unified Diff: components/autofill/core/browser/form_structure.h

Issue 22040002: [Autofill] Add a separate enumeration for HTML field type hints. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src
Patch Set: Add docs Created 7 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: components/autofill/core/browser/form_structure.h
diff --git a/components/autofill/core/browser/form_structure.h b/components/autofill/core/browser/form_structure.h
index 02f0044fa30632b8ad08cb7c9cea2dd3150583bb..16b8e89eba4c42e96abb8decba43b887cd411017 100644
--- a/components/autofill/core/browser/form_structure.h
+++ b/components/autofill/core/browser/form_structure.h
@@ -48,13 +48,6 @@ struct FormDataPredictions;
// in the fields along with additional information needed by Autofill.
class FormStructure {
public:
- // Whether the form fields should be parsed to match the semantics of plain
- // ol' Autofill, or of the interactive Autofill dialog.
- enum ParseTarget {
- PARSE_FOR_AUTOFILL,
- PARSE_FOR_AUTOFILL_DIALOG,
- };
-
FormStructure(const FormData& form,
const std::string& autocheckout_url_prefix);
virtual ~FormStructure();
@@ -138,15 +131,12 @@ class FormStructure {
// Classifies each field in |fields_| based upon its |autocomplete| attribute,
// if the attribute is available. The association is stored into the field's
- // |heuristic_type|. The exact method of classification depends on
- // |parse_target|, as the Autofill dialog has slightly different semantics
- // from regular ol' Autofill.
+ // |heuristic_type|.
// Fills |found_types| with |true| if the attribute is available and neither
// empty nor set to the special values "on" or "off" for at least one field.
// Fills |found_sections| with |true| if the attribute specifies a section for
// at least one field.
- void ParseFieldTypesFromAutocompleteAttributes(ParseTarget parse_target,
- bool* found_types,
+ void ParseFieldTypesFromAutocompleteAttributes(bool* found_types,
bool* found_sections);
const AutofillField* field(size_t index) const;

Powered by Google App Engine
This is Rietveld 408576698