[Autofill] Add a separate enumeration for HTML field type hints.

chrome/browser/ui/autofill/data_model_wrapper.cc

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "chrome/browser/ui/autofill/data_model_wrapper.h"
 
 #include "base/callback.h"
 #include "base/strings/utf_string_conversions.h"
 #include "chrome/browser/browser_process.h"
 #include "chrome/browser/ui/autofill/autofill_dialog_models.h"
@@ skipping 105 matching lines @@
   const std::string app_locale = g_browser_process->GetApplicationLocale();
   for (size_t j = 0; j < inputs->size(); ++j) {
     std::vector<string16> values;
     profile_->GetMultiInfo(
         AutofillType((*inputs)[j].type), app_locale, &values);
     (*inputs)[j].initial_value = values[variant()];
   }
 }
 
 void AutofillProfileWrapper::FillFormField(AutofillField* field) const {
-  AutofillType field_type = field->Type();
+  HtmlFieldType html_type = field->html_type();

[Evan Stade, 2013/08/05 18:47:24]

nit: declare as late as possible, not at top of function.

[Ilya Sherman, 2013/08/06 05:05:39]

Hmm, I'm not sure where you'd prefer to see this declared.  It needs to come
before line 133, since the goal is to cache the type prior to overwriting it;
and declaring the variable just within the if-stmt doesn't work, as the value
needs to be read at line 138.

[Evan Stade, 2013/08/06 18:39:59]

I see, I missed that. Can you give the variable a more descriptive name like
|original_html_type|? I also think the function would overall be easier to
understand as:

if (condition) {
  read old type, set temporary, fill, restore old type
} else {
  fill
}

This makes it clearer what's necessary under what circumstances, and only has to
repeat a single line.

[Ilya Sherman, 2013/08/06 23:04:56]

Done.

+  HtmlFieldMode html_mode = field->html_mode();
 
-  if (field_type.native_type() == CREDIT_CARD_NAME) {
+  if (field->Type().GetEquivalentNativeType() == CREDIT_CARD_NAME) {
     // Requests for the user's credit card are filled from the billing address,
     // but the AutofillProfile class doesn't know how to fill credit card
     // fields. So, temporarily set the type to the corresponding profile type.
-    field->set_heuristic_type(NAME_FULL);
+    field->SetHtmlType(HTML_TYPE_NAME, html_mode);
   }
 
   AutofillDataModelWrapper::FillFormField(field);
 
-  field->set_heuristic_type(field_type.native_type());
+  field->SetHtmlType(html_type, html_mode);
 }
 
 // AutofillCreditCardWrapper
 
 AutofillCreditCardWrapper::AutofillCreditCardWrapper(const CreditCard* card)
     : AutofillDataModelWrapper(card, 0),
       card_(card) {}
 
 AutofillCreditCardWrapper::~AutofillCreditCardWrapper() {}
 
 string16 AutofillCreditCardWrapper::GetInfo(const AutofillType& type) const {
-  if (type.native_type() == CREDIT_CARD_EXP_MONTH)
+  if (type.GetEquivalentNativeType() == CREDIT_CARD_EXP_MONTH)
     return MonthComboboxModel::FormatMonth(card_->expiration_month());
 
   return AutofillDataModelWrapper::GetInfo(type);
 }
 
 gfx::Image AutofillCreditCardWrapper::GetIcon() {
   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
   return rb.GetImageNamed(CreditCard::IconResourceId(card_->type()));
 }
 
@@ skipping 26 matching lines @@
 
 // WalletInstrumentWrapper
 
 WalletInstrumentWrapper::WalletInstrumentWrapper(
     const wallet::WalletItems::MaskedInstrument* instrument)
     : instrument_(instrument) {}
 
 WalletInstrumentWrapper::~WalletInstrumentWrapper() {}
 
 string16 WalletInstrumentWrapper::GetInfo(const AutofillType& type) const {
-  if (type.native_type() == CREDIT_CARD_EXP_MONTH)
+  if (type.GetEquivalentNativeType() == CREDIT_CARD_EXP_MONTH)
     return MonthComboboxModel::FormatMonth(instrument_->expiration_month());
 
   return instrument_->GetInfo(type, g_browser_process->GetApplicationLocale());
 }
 
 gfx::Image WalletInstrumentWrapper::GetIcon() {
   return instrument_->CardIcon();
 }
 
 string16 WalletInstrumentWrapper::GetDisplayText() {
@@ skipping 14 matching lines @@
 
 FullWalletBillingWrapper::FullWalletBillingWrapper(
     wallet::FullWallet* full_wallet)
     : full_wallet_(full_wallet) {
   DCHECK(full_wallet_);
 }
 
 FullWalletBillingWrapper::~FullWalletBillingWrapper() {}
 
 string16 FullWalletBillingWrapper::GetInfo(const AutofillType& type) const {
-  if (type.native_type() == CREDIT_CARD_EXP_MONTH)
+  if (type.GetEquivalentNativeType() == CREDIT_CARD_EXP_MONTH)
     return MonthComboboxModel::FormatMonth(full_wallet_->expiration_month());
 
   if (type.group() == CREDIT_CARD)
     return full_wallet_->GetInfo(type);
 
   return full_wallet_->billing_address()->GetInfo(
       type, g_browser_process->GetApplicationLocale());
 }
 
 string16 FullWalletBillingWrapper::GetDisplayText() {
@@ skipping 18 matching lines @@
   return full_wallet_->shipping_address()->GetInfo(
       type, g_browser_process->GetApplicationLocale());
 }
 
 DetailOutputWrapper::DetailOutputWrapper(const DetailOutputMap& outputs)
     : outputs_(outputs) {}
 
 DetailOutputWrapper::~DetailOutputWrapper() {}
 
 base::string16 DetailOutputWrapper::GetInfo(const AutofillType& type) const {
+  NativeFieldType native_type = type.GetEquivalentNativeType();
   for (DetailOutputMap::const_iterator it = outputs_.begin();
        it != outputs_.end(); ++it) {
-    if (type.native_type() == it->first->type)
+    if (native_type == AutofillType(it->first->type).GetEquivalentNativeType())
       return it->second;
   }
   return base::string16();
 }
 
 }  // namespace autofill