components/omnibox/browser/omnibox_metrics_provider.cc - Issue 2203993002: Add a Physical Web omnibox autocomplete provider

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/omnibox/browser/omnibox_metrics_provider.cc

Issue 2203993002: Add a Physical Web omnibox autocomplete provider (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: data source changes Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: components/omnibox/browser/omnibox_metrics_provider.cc

diff --git a/components/omnibox/browser/omnibox_metrics_provider.cc b/components/omnibox/browser/omnibox_metrics_provider.cc

index 619ea4d69898bd4a9c8edadf3b98f11fd35ea2d3..dd620d7d93cb75effd6afb409703bff6b3576e79 100644

--- a/components/omnibox/browser/omnibox_metrics_provider.cc

+++ b/components/omnibox/browser/omnibox_metrics_provider.cc

@@ -64,6 +64,8 @@ OmniboxEventProto::Suggestion::ResultType AsOmniboxEventResultType(

return OmniboxEventProto::Suggestion::NAVSUGGEST_PERSONALIZED;

case AutocompleteMatchType::CLIPBOARD:

return OmniboxEventProto::Suggestion::CLIPBOARD;

+ case AutocompleteMatchType::PHYSICAL_WEB:

+ return OmniboxEventProto::Suggestion::PHYSICAL_WEB;

case AutocompleteMatchType::VOICE_SUGGEST:

// VOICE_SUGGEST matches are only used in Java and are not logged,

// so we should never reach this case.