Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(282)

Unified Diff: src/core/SkCanvas.cpp

Issue 2203983002: Fix copy-paste bugs in SkCanvas Nine and Lattice (Closed) Base URL: https://skia.googlesource.com/skia.git@master
Patch Set: Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/core/SkCanvas.cpp
diff --git a/src/core/SkCanvas.cpp b/src/core/SkCanvas.cpp
index 648059a1965cdbc71c1e6a4eee19931ca6dd9bd1..571b9b756e1f1e7d08b24dd7f59eb5245684c715 100644
--- a/src/core/SkCanvas.cpp
+++ b/src/core/SkCanvas.cpp
@@ -1986,7 +1986,7 @@ void SkCanvas::drawImageNine(const SkImage* image, const SkIRect& center, const
return;
}
if (!SkLatticeIter::Valid(image->width(), image->height(), center)) {
- this->drawImageRect(image, dst, paint);
+ return this->drawImageRect(image, dst, paint);
msarett 2016/08/02 21:47:48 I think this is a bug?
reed1 2016/08/03 13:13:05 return void is odd. How about if (Valid) { th
msarett 2016/08/03 13:20:52 Done.
}
this->onDrawImageNine(image, center, dst, paint);
}
@@ -2023,7 +2023,7 @@ void SkCanvas::drawBitmapNine(const SkBitmap& bitmap, const SkIRect& center, con
return;
}
if (!SkLatticeIter::Valid(bitmap.width(), bitmap.height(), center)) {
- this->drawBitmapRect(bitmap, dst, paint);
+ return this->drawBitmapRect(bitmap, dst, paint);
msarett 2016/08/02 21:47:48 Ditto
reed1 2016/08/03 13:13:05 ditto
msarett 2016/08/03 13:20:52 Done.
}
this->onDrawBitmapNine(bitmap, center, dst, paint);
}
@@ -2041,7 +2041,7 @@ void SkCanvas::drawImageLattice(const SkImage* image, const Lattice& lattice, co
return;
}
if (!SkLatticeIter::Valid(image->width(), image->height(), lattice)) {
- this->drawImageRect(image, dst, paint);
+ return this->drawImageRect(image, dst, paint);
msarett 2016/08/02 21:47:48 Pretty sure this is a bug, since I wrote it...
msarett 2016/08/03 13:20:52 Done.
}
this->onDrawImageLattice(image, lattice, dst, paint);
}
« no previous file with comments | « no previous file | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698