Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(873)

Issue 2203963002: [Autofill] Credit Card Signin promo: no bg color, no smaller font. (Closed)

Created:
4 years, 4 months ago by Mathieu
Modified:
4 years, 4 months ago
Reviewers:
Evan Stade
CC:
chromium-reviews, rouslan+autofill_chromium.org, estade+watch_chromium.org, vabr+watchlistautofill_chromium.org, jdonnelly+autofillwatch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

[Autofill] Credit Card Signin promo: no bg color, no smaller font. BUG=626442 TEST=manual Committed: https://crrev.com/d115ca02cd675e99deb36a66a273468f78ed7360 Cr-Commit-Position: refs/heads/master@{#409507}

Patch Set 1 #

Total comments: 1

Patch Set 2 : removed kWarningTextColor #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -9 lines) Patch
M chrome/browser/ui/autofill/autofill_popup_controller_impl.cc View 1 chunk +0 lines, -4 lines 0 comments Download
M chrome/browser/ui/autofill/autofill_popup_layout_model.cc View 1 chunk +1 line, -2 lines 0 comments Download
M chrome/browser/ui/autofill/popup_constants.h View 1 1 chunk +0 lines, -2 lines 0 comments Download
M chrome/browser/ui/views/autofill/autofill_popup_view_views.cc View 1 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 11 (6 generated)
Mathieu
Hi Evan, PTAL
4 years, 4 months ago (2016-08-02 21:14:12 UTC) #3
Evan Stade
lgtm https://codereview.chromium.org/2203963002/diff/1/chrome/browser/ui/autofill/popup_constants.h File chrome/browser/ui/autofill/popup_constants.h (right): https://codereview.chromium.org/2203963002/diff/1/chrome/browser/ui/autofill/popup_constants.h#newcode19 chrome/browser/ui/autofill/popup_constants.h:19: const SkColor kWarningTextColor = SkColorSetRGB(0x64, 0x64, 0x64); nit: ...
4 years, 4 months ago (2016-08-03 12:53:45 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203963002/20001
4 years, 4 months ago (2016-08-03 13:32:41 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 4 months ago (2016-08-03 14:15:28 UTC) #9
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 14:16:54 UTC) #11
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/d115ca02cd675e99deb36a66a273468f78ed7360
Cr-Commit-Position: refs/heads/master@{#409507}

Powered by Google App Engine
This is Rietveld 408576698