Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(51)

Issue 2203953002: mus: Remove DCHECK that was causing false positives. (Closed)

Created:
4 years, 4 months ago by Elliot Glaysher
Modified:
4 years, 4 months ago
Reviewers:
sadrul
CC:
chromium-reviews, rjkroege
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

mus: Remove DCHECK that was causing false positives. When translating from a key event to a character event, it's valid to have the character change, ie, from 'M' to '^M'. BUG=633401 Committed: https://crrev.com/663728cb129b3ce5740a9b31adc9a190e283e903 Cr-Commit-Position: refs/heads/master@{#409368}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -1 line) Patch
M services/ui/ws/platform_display.cc View 1 chunk +3 lines, -1 line 0 comments Download

Messages

Total messages: 12 (7 generated)
Elliot Glaysher
4 years, 4 months ago (2016-08-02 20:56:38 UTC) #4
sadrul
lgtm
4 years, 4 months ago (2016-08-02 22:45:40 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203953002/1
4 years, 4 months ago (2016-08-02 22:52:40 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 22:57:27 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 22:59:59 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/663728cb129b3ce5740a9b31adc9a190e283e903
Cr-Commit-Position: refs/heads/master@{#409368}

Powered by Google App Engine
This is Rietveld 408576698