third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.h - Issue 2203933002: Replace LayoutObject::skipInvalidationWhenLaidOutChildren() with paintedOutputOfObjectHasNoEffect

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.h

Issue 2203933002: Replace LayoutObject::skipInvalidationWhenLaidOutChildren() with paintedOutputOfObjectHasNoEffect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix first line invalidation issue Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/layout/LayoutView.cpp ('k') | third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.h

diff --git a/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.h b/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.h

index 629f7b4f2196f39291af351a22658e2785bb50db..542087ebd76d1a83c9e434fba7234680a2455330 100644

--- a/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.h

+++ b/third_party/WebKit/Source/core/layout/svg/LayoutSVGHiddenContainer.h

@@ -40,10 +40,12 @@ protected:

bool isOfType(LayoutObjectType type) const override { return type == LayoutObjectSVGHiddenContainer || LayoutSVGContainer::isOfType(type); }

private:

- void paint(const PaintInfo&, const LayoutPoint&) const final;

+ // LayoutSVGHiddenContainer paints nothing.

+ void paint(const PaintInfo&, const LayoutPoint&) const final { }

+ bool paintedOutputOfObjectHasNoEffect() const final { return true; }

LayoutRect absoluteClippedOverflowRect() const final { return LayoutRect(); }

FloatRect paintInvalidationRectInLocalSVGCoordinates() const final { return FloatRect(); }

- void absoluteQuads(Vector<FloatQuad>&) const final;

+ void absoluteQuads(Vector<FloatQuad>&) const final { }

bool nodeAtFloatPoint(HitTestResult&, const FloatPoint& pointInParent, HitTestAction) final;

};