third_party/WebKit/Source/core/layout/LayoutBlockFlow.h - Issue 2203933002: Replace LayoutObject::skipInvalidationWhenLaidOutChildren() with paintedOutputOfObjectHasNoEffect

Side by Side Diff: third_party/WebKit/Source/core/layout/LayoutBlockFlow.h

Issue 2203933002: Replace LayoutObject::skipInvalidationWhenLaidOutChildren() with paintedOutputOfObjectHasNoEffect (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix first line invalidation issue Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « third_party/WebKit/LayoutTests/css3/flexbox/repaint-on-margin-change-expected.html ('k') | third_party/WebKit/Source/core/layout/LayoutBlockFlowLine.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 /*	1 /*

2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)	2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)

3 * (C) 1999 Antti Koivisto (koivisto@kde.org)	3 * (C) 1999 Antti Koivisto (koivisto@kde.org)

4 * (C) 2007 David Smith (catfish.man@gmail.com)	4 * (C) 2007 David Smith (catfish.man@gmail.com)

5 * Copyright (C) 2003-2013 Apple Inc. All rights reserved.	5 * Copyright (C) 2003-2013 Apple Inc. All rights reserved.

6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.	6 * Copyright (C) Research In Motion Limited 2010. All rights reserved.

7 * Copyright (C) 2013 Google Inc. All rights reserved.	7 * Copyright (C) 2013 Google Inc. All rights reserved.

8 *	8 *

9 * Redistribution and use in source and binary forms, with or without	9 * Redistribution and use in source and binary forms, with or without

10 * modification, are permitted provided that the following conditions are	10 * modification, are permitted provided that the following conditions are

(...skipping 323 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
334	334

335 virtual LayoutObject* layoutSpecialExcludedChild(bool /relayoutChildren/, SubtreeLayoutScope&);	335 virtual LayoutObject* layoutSpecialExcludedChild(bool /relayoutChildren/, SubtreeLayoutScope&);

336 bool updateLogicalWidthAndColumnWidth() override;	336 bool updateLogicalWidthAndColumnWidth() override;

337	337

338 void setLogicalLeftForChild(LayoutBox& child, LayoutUnit logicalLeft);	338 void setLogicalLeftForChild(LayoutBox& child, LayoutUnit logicalLeft);

339 void setLogicalTopForChild(LayoutBox& child, LayoutUnit logicalTop);	339 void setLogicalTopForChild(LayoutBox& child, LayoutUnit logicalTop);

340 void determineLogicalLeftPositionForChild(LayoutBox& child);	340 void determineLogicalLeftPositionForChild(LayoutBox& child);

341	341

342 void addOutlineRects(Vector<LayoutRect>&, const LayoutPoint& additionalOffse t, IncludeBlockVisualOverflowOrNot) const override;	342 void addOutlineRects(Vector<LayoutRect>&, const LayoutPoint& additionalOffse t, IncludeBlockVisualOverflowOrNot) const override;

343	343

	344 bool paintedOutputOfObjectHasNoEffect() const override;

344 PaintInvalidationReason invalidatePaintIfNeeded(const PaintInvalidationState &) override;	345 PaintInvalidationReason invalidatePaintIfNeeded(const PaintInvalidationState &) override;

345	346

346 Node* nodeForHitTest() const final;	347 Node* nodeForHitTest() const final;

347 bool hitTestChildren(HitTestResult&, const HitTestLocation& locationInContai ner, const LayoutPoint& accumulatedOffset, HitTestAction) override;	348 bool hitTestChildren(HitTestResult&, const HitTestLocation& locationInContai ner, const LayoutPoint& accumulatedOffset, HitTestAction) override;

348	349

349 LayoutSize accumulateInFlowPositionOffsets() const override;	350 LayoutSize accumulateInFlowPositionOffsets() const override;

350	351

351 private:	352 private:

352 bool layoutBlockFlow(bool relayoutChildren, LayoutUnit& pageLogicalHeight, S ubtreeLayoutScope&);	353 bool layoutBlockFlow(bool relayoutChildren, LayoutUnit& pageLogicalHeight, S ubtreeLayoutScope&);

353 void layoutBlockChildren(bool relayoutChildren, SubtreeLayoutScope&, LayoutU nit beforeEdge, LayoutUnit afterEdge);	354 void layoutBlockChildren(bool relayoutChildren, SubtreeLayoutScope&, LayoutU nit beforeEdge, LayoutUnit afterEdge);

(...skipping 305 matching lines...) Expand 10 before \| Expand all \| Expand 10 after Loading...
659	660

660 // END METHODS DEFINED IN LayoutBlockFlowLine	661 // END METHODS DEFINED IN LayoutBlockFlowLine

661	662

662 };	663 };

663	664

664 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlockFlow, isLayoutBlockFlow());	665 DEFINE_LAYOUT_OBJECT_TYPE_CASTS(LayoutBlockFlow, isLayoutBlockFlow());

665	666

666 } // namespace blink	667 } // namespace blink

667	668

668 #endif // LayoutBlockFlow_h	669 #endif // LayoutBlockFlow_h

OLD	NEW