Add a unit test for resetting the app list on a reshow.

Add a unit test for app list resetting correctly.

This CL adds a test for the app list showing the correct view when it
hides and reshows. This tests the behavior introduced in
https://codereview.chromium.org/214423002/.

BUG=357058
Committed: https://src.chromium.org/viewvc/chrome?view=rev&revision=272777

[tapted, 2014-04-01 06:28:26]

looks good! mostly nits

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/test/app_lis...
File ui/app_list/test/app_list_test_model.cc (right):

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/test/app_lis...
ui/app_list/test/app_list_test_model.cc:24: SkBitmap bitmap;
In my demo code I'm doing

  ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
  SetIcon(*rb.GetImageNamed(IDR_DEFAULT_FAVICON_32).ToImageSkia());

it might even be less work because the bitmap is shared, and I think skia is
smart enough to only resize it once. WDYT?

Oddly there were exactly zero icons in ui_resources.grd with dimensions 48x48.

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/views/app_li...
File ui/app_list/views/app_list_view_unittest.cc (right):

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/views/app_li...
ui/app_list/views/app_list_view_unittest.cc:9: #include
"base/strings/string_util.h."
make sure you rebase to avoid my derp :p

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/views/app_li...
ui/app_list/views/app_list_view_unittest.cc:195: 
Can you 

EXPECT_FALSE(container_view->app_list_folder_view()->visible());

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/views/app_li...
ui/app_list/views/app_list_view_unittest.cc:202: 
and

EXPECT_FALSE(container_view->apps_grid_view()->visible());

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/views/app_li...
ui/app_list/views/app_list_view_unittest.cc:210:
EXPECT_NO_FATAL_FAILURE(CheckView(container_view->apps_grid_view()));
EXPECT_FALSE(container_view->app_list_folder_view()->visible());

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/views/test/a...
File ui/app_list/views/test/apps_grid_view_test_api.cc (right):

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/views/test/a...
ui/app_list/views/test/apps_grid_view_test_api.cc:35: view_->ButtonPressed(
what about 

GetViewAtModelIndex(index)->OnKeyPressed(
    ui::KeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_RETURN, 0, false)));

slightly less arbitrary (wrt coordinates), and should avoid the static cast.

[calamity, 2014-04-01 08:08:46]

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/test/app_lis...
File ui/app_list/test/app_list_test_model.cc (right):

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/test/app_lis...
ui/app_list/test/app_list_test_model.cc:24: SkBitmap bitmap;
On 2014/04/01 06:28:27, tapted wrote:
> In my demo code I'm doing
> 
>   ui::ResourceBundle& rb = ui::ResourceBundle::GetSharedInstance();
>   SetIcon(*rb.GetImageNamed(IDR_DEFAULT_FAVICON_32).ToImageSkia());
> 
> it might even be less work because the bitmap is shared, and I think skia is
> smart enough to only resize it once. WDYT?
> 
> Oddly there were exactly zero icons in ui_resources.grd with dimensions 48x48.

Done.

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/views/app_li...
File ui/app_list/views/app_list_view_unittest.cc (right):

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/views/app_li...
ui/app_list/views/app_list_view_unittest.cc:9: #include
"base/strings/string_util.h."
On 2014/04/01 06:28:27, tapted wrote:
> make sure you rebase to avoid my derp :p

Done.

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/views/app_li...
ui/app_list/views/app_list_view_unittest.cc:195: 
On 2014/04/01 06:28:27, tapted wrote:
> Can you 
> 
> EXPECT_FALSE(container_view->app_list_folder_view()->visible());

Done.

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/views/app_li...
ui/app_list/views/app_list_view_unittest.cc:202: 
On 2014/04/01 06:28:27, tapted wrote:
> and
> 
> EXPECT_FALSE(container_view->apps_grid_view()->visible());

Done.

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/views/app_li...
ui/app_list/views/app_list_view_unittest.cc:210:
EXPECT_NO_FATAL_FAILURE(CheckView(container_view->apps_grid_view()));
On 2014/04/01 06:28:27, tapted wrote:
> EXPECT_FALSE(container_view->app_list_folder_view()->visible());

Done.

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/views/test/a...
File ui/app_list/views/test/apps_grid_view_test_api.cc (right):

https://codereview.chromium.org/220393003/diff/40001/ui/app_list/views/test/a...
ui/app_list/views/test/apps_grid_view_test_api.cc:35: view_->ButtonPressed(
On 2014/04/01 06:28:27, tapted wrote:
> what about 
> 
> GetViewAtModelIndex(index)->OnKeyPressed(
>     ui::KeyEvent(ui::ET_KEY_PRESSED, ui::VKEY_RETURN, 0, false)));
> 
> slightly less arbitrary (wrt coordinates), and should avoid the static cast.

Done.

[tapted, 2014-05-20 05:09:35]

this should be safe to rebase now and land. It L pretty GTM, but the test
harness has changed a bit.

[calamity, 2014-05-22 00:46:54]

Rebased.

[tapted, 2014-05-22 01:21:10]

https://codereview.chromium.org/220393003/diff/210001/ui/app_list/views/app_l...
File ui/app_list/views/app_list_view_unittest.cc (right):

https://codereview.chromium.org/220393003/diff/210001/ui/app_list/views/app_l...
ui/app_list/views/app_list_view_unittest.cc:323:
INSTANTIATE_TEST_CASE_P(AppListViewTestAuraInstance,
You'll need lines like these for any `TEST_P` test

[tapted, 2014-05-22 01:27:43]

lgtm

https://codereview.chromium.org/220393003/diff/210001/ui/app_list/views/app_l...
File ui/app_list/views/app_list_view_unittest.cc (right):

https://codereview.chromium.org/220393003/diff/210001/ui/app_list/views/app_l...
ui/app_list/views/app_list_view_unittest.cc:323:
INSTANTIATE_TEST_CASE_P(AppListViewTestAuraInstance,
On 2014/05/22 01:21:10, tapted wrote:
> You'll need lines like these for any `TEST_P` test

oops - you're right. This TEST_P stuff is more useful than I thought.

[calamity, 2014-05-22 01:33:54]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-05-22 01:36:26]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/calamity@chromium.org/220393003/210001

[commit-bot: I haz the power, 2014-05-22 08:18:15]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-22 09:59:12]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-22 09:59:13]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[calamity, 2014-05-23 03:09:38]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-05-23 03:11:31]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/calamity@chromium.org/220393003/220001

[commit-bot: I haz the power, 2014-05-23 07:05:31]

FYI, CQ is re-trying this CL (attempt #1).
Please consider checking whether the failures are real,
and report flakes to chrome-troopers@google.com.
The failing builders are:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)
  win_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/win_chromium_rel/buil...)

[commit-bot: I haz the power, 2014-05-23 09:11:00]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-05-23 09:11:01]

Try jobs failed on following builders:
  mac_chromium_rel on tryserver.chromium
(http://build.chromium.org/p/tryserver.chromium/builders/mac_chromium_rel/buil...)

[calamity, 2014-05-26 00:37:08]

The CQ bit was checked by calamity@chromium.org

[commit-bot: I haz the power, 2014-05-26 00:37:23]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/calamity@chromium.org/220393003/220001

[commit-bot: I haz the power, 2014-05-26 04:03:15]

Change committed as 272777