Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(713)

Issue 2203923003: Removing remaining asserts while I debug flakiness in minidump tests. (Closed)

Created:
4 years, 4 months ago by eyaich
Modified:
4 years, 4 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org, kozy
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Removing remaining asserts while I debug flakiness in minidump tests. BUG=633761 Committed: https://crrev.com/f4e1369980c341f7aa22d59600abfff43939f53e Cr-Commit-Position: refs/heads/master@{#409398}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -3 lines) Patch
M tools/perf/core/minidump_unittest.py View 3 chunks +3 lines, -3 lines 0 comments Download

Messages

Total messages: 8 (3 generated)
eyaich
4 years, 4 months ago (2016-08-02 23:20:45 UTC) #2
nednguyen
lgtm
4 years, 4 months ago (2016-08-02 23:26:12 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203923003/1
4 years, 4 months ago (2016-08-02 23:26:52 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 00:23:57 UTC) #6
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 00:26:43 UTC) #8
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f4e1369980c341f7aa22d59600abfff43939f53e
Cr-Commit-Position: refs/heads/master@{#409398}

Powered by Google App Engine
This is Rietveld 408576698