Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(237)

Unified Diff: third_party/WebKit/Source/core/frame/UseCounter.cpp

Issue 2203913002: Added trace events for blink feature usage (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Only trace first use of each feature Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: third_party/WebKit/Source/core/frame/UseCounter.cpp
diff --git a/third_party/WebKit/Source/core/frame/UseCounter.cpp b/third_party/WebKit/Source/core/frame/UseCounter.cpp
index 3f8b28145a80dd664e03efecd65de04f7d4df42d..04af5eb19a4e25ce3d9ea4d6a93749addd6a5cf1 100644
--- a/third_party/WebKit/Source/core/frame/UseCounter.cpp
+++ b/third_party/WebKit/Source/core/frame/UseCounter.cpp
@@ -36,6 +36,7 @@
#include "core/inspector/ConsoleMessage.h"
#include "core/workers/WorkerGlobalScope.h"
#include "platform/Histogram.h"
+#include "platform/TraceEvent.h"
namespace blink {
@@ -599,6 +600,17 @@ void UseCounter::unmuteForInspector()
m_muteCount--;
}
+void UseCounter::recordMeasurement(Feature feature)
+{
+ if (m_muteCount)
+ return;
+
+ if (!m_countBits.hasRecordedMeasurement(feature)) {
+ TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("blink.feature_usage"), "FeatureFirstUsed", "feature", feature);
+ }
+ m_countBits.recordMeasurement(feature);
+}
+
UseCounter::UseCounter()
: m_muteCount(0)
{
@@ -662,8 +674,7 @@ void UseCounter::count(const Frame* frame, Feature feature)
if (!host)
return;
- ASSERT(Deprecation::deprecationMessage(feature).isEmpty());
- host->useCounter().recordMeasurement(feature);
+ host->useCounter().count(feature);
}
void UseCounter::count(const Document& document, Feature feature)
@@ -751,6 +762,9 @@ void UseCounter::count(CSSParserMode cssParserMode, CSSPropertyID feature)
if (!isUseCounterEnabledForMode(cssParserMode) || m_muteCount)
return;
+ if (!m_CSSFeatureBits.quickGet(feature)) {
+ TRACE_EVENT1(TRACE_DISABLED_BY_DEFAULT("blink.feature_usage"), "CSSFeatureFirstUsed", "feature", feature);
+ }
m_CSSFeatureBits.quickSet(feature);
}
« no previous file with comments | « third_party/WebKit/Source/core/frame/UseCounter.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698