third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp - Issue 2203903002: Color: Read embedded ICC profiles regardless of QCMS

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

Issue 2203903002: Color: Read embedded ICC profiles regardless of QCMS (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Add plumbing through to ImageFrame Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp ('K') | « third_party/WebKit/Source/platform/image-decoders/bmp/BMPImageReader.cpp ('k') | third_party/WebKit/Source/platform/image-decoders/ico/ICOImageDecoder.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

diff --git a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

index 72f2c834ae95c11df7e2e03cee1975a0e5591c08..a769b6d09bb28180c851a3f3e7128ba6077dbcf1 100644

--- a/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

+++ b/third_party/WebKit/Source/platform/image-decoders/gif/GIFImageDecoder.cpp

@@ -353,7 +353,7 @@ bool GIFImageDecoder::initFrameBuffer(size_t frameIndex)

size_t requiredPreviousFrameIndex = buffer->requiredPreviousFrameIndex();

if (requiredPreviousFrameIndex == kNotFound) {

// This frame doesn't rely on any previous data.

- if (!buffer->setSize(size().width(), size().height()))

+ if (!buffer->setSizeAndColorProfile(size().width(), size().height(), ImageFrame::ICCProfile()))

return setFailed();

} else {

const ImageFrame* prevBuffer = &m_frameBufferCache[requiredPreviousFrameIndex];