Color: Read embedded ICC profiles regardless of QCMS

Color: Read embedded ICC profiles regardless of QCMS

Move code to load embedded ICC profiles out from behind the QCMS guard.

Add plumbing for the ICC profile from ImageDecoder to ImageFrame, where
the relevant SkBitmap is loaded.

BUG=44872
Committed: https://crrev.com/453bdc54a3650850eb8f8c5b5ca58f5db48df73d
Cr-Commit-Position: refs/heads/master@{#409942}

[ccameron, 2016-08-02 19:26:49]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 19:28:06]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-08-02 19:29:50]

Description was changed from

==========
Color: Always read embedded ICC profiles

Change GammaAndColorProfileIgnored to GammaAndColorProfileNotApplied,
to be more clear about the behavior.

Clean up

BUG=44872
==========

to

==========
Color: Always read embedded ICC profiles

Move code to load embedded ICC profiles out from behind the QCMS guard.

Be more precise about the difference between the existence of an embedded
ICC profile and whether or not a transform has been baked into the pixels.

Change GammaAndColorProfileIgnored to GammaAndColorProfileNotApplied,
and change m_ignoreGammaAndColorProfile to m_bakeColorTransformToPixels.

BUG=44872
==========

[ccameron, 2016-08-02 19:43:36]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 19:43:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-08-02 20:27:46]

Description was changed from

==========
Color: Always read embedded ICC profiles

Move code to load embedded ICC profiles out from behind the QCMS guard.

Be more precise about the difference between the existence of an embedded
ICC profile and whether or not a transform has been baked into the pixels.

Change GammaAndColorProfileIgnored to GammaAndColorProfileNotApplied,
and change m_ignoreGammaAndColorProfile to m_bakeColorTransformToPixels.

BUG=44872
==========

to

==========
Color: Always read embedded ICC profiles, add plumbing

Move code to load embedded ICC profiles out from behind the QCMS guard.

Be more precise about the difference between the existence of an embedded
ICC profile and whether or not a transform has been baked into the pixels.

Change GammaAndColorProfileIgnored to GammaAndColorProfileNotApplied,
and change m_ignoreGammaAndColorProfile to m_bakeColorTransformToPixels.

Add plumbing for the ICC profile from ImageDecoder to ImageFrame, where
the relevant SkBitmap is loaded.

BUG=44872
==========

[ccameron, 2016-08-02 20:27:46]

ccameron@chromium.org changed reviewers:
+ junov@chromium.org

[ccameron, 2016-08-02 20:28:51]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-02 20:29:24]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-08-02 20:31:31]

https://codereview.chromium.org/2203903002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp (right):

https://codereview.chromium.org/2203903002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/image-decoders/ImageFrame.cpp:102: // with
newIccProfile, under a runtime flag.
Next patch will add this runtime flag. I've tested by printf-ing, and skia has
been able to read the ICC profiles from my test pages.

[commit-bot: I haz the power, 2016-08-02 21:27:23]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-02 21:27:24]

Dry run: Try jobs failed on following builders:
  linux_android_rel_ng on master.tryserver.chromium.android (JOB_FAILED,
https://build.chromium.org/p/tryserver.chromium.android/builders/linux_androi...)

[Justin Novosad, 2016-08-02 22:49:13]

https://codereview.chromium.org/2203903002/diff/40001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h (right):

https://codereview.chromium.org/2203903002/diff/40001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/image-decoders/ImageDecoder.h:94:
GammaAndColorProfileNotApplied
You still need to keep the "Ignore" option IMHO.  Webgl and ImageBitmap have
special use cases that require this this semantic. 
NotApplied means that the color profile should be applied downstream.
Ignore means no color transformation should ever be applied, so do not attach
color profile data to the decoded image.

The ignore setting is used for stuff like loading webgl textures that have
non-color data (like bump maps, for example)

[ccameron, 2016-08-03 18:42:16]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-03 18:43:04]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-03 20:42:49]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-03 20:42:50]

Dry run: Try jobs failed on following builders:
  win_chromium_rel_ng on master.tryserver.chromium.win (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[ccameron, 2016-08-03 22:13:11]

Description was changed from

==========
Color: Always read embedded ICC profiles, add plumbing

Move code to load embedded ICC profiles out from behind the QCMS guard.

Be more precise about the difference between the existence of an embedded
ICC profile and whether or not a transform has been baked into the pixels.

Change GammaAndColorProfileIgnored to GammaAndColorProfileNotApplied,
and change m_ignoreGammaAndColorProfile to m_bakeColorTransformToPixels.

Add plumbing for the ICC profile from ImageDecoder to ImageFrame, where
the relevant SkBitmap is loaded.

BUG=44872
==========

to

==========
Color: Read embedded ICC profiles regardless of QCMS

Move code to load embedded ICC profiles out from behind the QCMS guard.

Add plumbing for the ICC profile from ImageDecoder to ImageFrame, where
the relevant SkBitmap is loaded.

BUG=44872
==========

[ccameron, 2016-08-03 22:14:03]

Good point -- that was causing the WebGL test failure that happened later.

Updated.

[Justin Novosad, 2016-08-03 22:59:03]

This is looking good IMHO.  Let's get this committed. I think we are missing
just a few things to make this committable
* hide the new behavior behind a runtime flag 
* some tests.
* setting up the content layer's SkSurface to give it a color space so that
color management is enabled at raster time.  (could be in a follow-up CL)

Idea: if you put the flag in RuntimeEnabledFeatures.in with
settable_from_internals=True, then you can write layout tests that use
window.internals.runtimeFlags.ColorManagedContentLayers = true to enable
colormangement just for the scope of the test, without creating a virtual test
suite.

[ccameron, 2016-08-04 20:38:30]

The CQ bit was checked by ccameron@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-08-04 20:38:50]

Dry run: CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[ccameron, 2016-08-04 22:07:29]

Oh -- adding a test for this turned out to be very simple!

I'm leaving out the plumb-the-flag-the-whole-way patch for now, since it's
mostly unrelated to this decode bit.

https://codereview.chromium.org/2203903002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp (right):

https://codereview.chromium.org/2203903002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp:221:
TEST_F(BitmapImageTest, jpegHasColorProfile)
Oh, oops, should have added these tests.

[commit-bot: I haz the power, 2016-08-04 22:19:32]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-08-04 22:19:33]

Dry run: This issue passed the CQ dry run.

[Justin Novosad, 2016-08-05 00:06:52]

lgtm

https://codereview.chromium.org/2203903002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp (right):

https://codereview.chromium.org/2203903002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/graphics/BitmapImageTest.cpp:221:
TEST_F(BitmapImageTest, jpegHasColorProfile)
On 2016/08/04 22:07:29, ccameron wrote:
> Oh, oops, should have added these tests.

LOL!

[ccameron, 2016-08-05 00:16:28]

Thanks!

[ccameron, 2016-08-05 00:16:33]

The CQ bit was checked by ccameron@chromium.org

[commit-bot: I haz the power, 2016-08-05 00:16:55]

CQ is trying da patch. Follow status at
 
https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.or...

[commit-bot: I haz the power, 2016-08-05 00:21:17]

Description was changed from

==========
Color: Read embedded ICC profiles regardless of QCMS

Move code to load embedded ICC profiles out from behind the QCMS guard.

Add plumbing for the ICC profile from ImageDecoder to ImageFrame, where
the relevant SkBitmap is loaded.

BUG=44872
==========

to

==========
Color: Read embedded ICC profiles regardless of QCMS

Move code to load embedded ICC profiles out from behind the QCMS guard.

Add plumbing for the ICC profile from ImageDecoder to ImageFrame, where
the relevant SkBitmap is loaded.

BUG=44872
==========

[commit-bot: I haz the power, 2016-08-05 00:21:22]

Committed patchset #5 (id:80001)

[commit-bot: I haz the power, 2016-08-05 00:23:36]

Description was changed from

==========
Color: Read embedded ICC profiles regardless of QCMS

Move code to load embedded ICC profiles out from behind the QCMS guard.

Add plumbing for the ICC profile from ImageDecoder to ImageFrame, where
the relevant SkBitmap is loaded.

BUG=44872
==========

to

==========
Color: Read embedded ICC profiles regardless of QCMS

Move code to load embedded ICC profiles out from behind the QCMS guard.

Add plumbing for the ICC profile from ImageDecoder to ImageFrame, where
the relevant SkBitmap is loaded.

BUG=44872

Committed: https://crrev.com/453bdc54a3650850eb8f8c5b5ca58f5db48df73d
Cr-Commit-Position: refs/heads/master@{#409942}
==========

[commit-bot: I haz the power, 2016-08-05 00:23:38]

Patchset 5 (id:??) landed as
https://crrev.com/453bdc54a3650850eb8f8c5b5ca58f5db48df73d
Cr-Commit-Position: refs/heads/master@{#409942}