Tree-shaker: Use insertion in the work queue instead of "was compiled" as the criterion to retain a…

Tree-shaker: Use insertion in the work queue instead of "was compiled" as the criterion to retain a function.

Allows dropping const constructors never used as non-const constructors nor roots.

R=fschneider@google.com

Committed: https://github.com/dart-lang/sdk/commit/908309fe6d239f80711ca4329367974c0265e52f

[rmacnak, 2016-08-02 18:01:12]

rmacnak@google.com changed reviewers:
+ fschneider@google.com, vegorov@google.com

[rmacnak, 2016-08-02 18:01:12]

rmacnak@prometheus:~/dart2/sdk$ cat a.dart
class FFFF {
  final int val;
  const FFFF(this.val);

  static final FFFF theFFFF = const FFFF(0);
}

main() {
  print(FFFF.theFFFF.val);
}


BEFORE
rmacnak@prometheus:~/dart2/sdk$ ~/dart4/sdk/./out/DebugX64/dart_bootstrap
--snapshot=$PWD --snapshot-kind=app-aot ./a.dart 
VMIsolate(CodeSize): 40381
Isolate(CodeSize): 844760
Instructions(CodeSize): 3512712
Total(CodeSize): 4397853

rmacnak@prometheus:~/dart2/sdk$ cat snapshot.S | grep FFFF
Precompiled_FFFF_get_val_3639:
Precompiled_FFFF_FFFF__3640:
Precompiled_FFFF_init_theFFFF_3641:

AFTER
rmacnak@prometheus:~/dart2/sdk$ ./out/DebugX64/dart_bootstrap --snapshot=$PWD
--snapshot-kind=app-aot ./a.dart 
VMIsolate(CodeSize): 39661
Isolate(CodeSize): 838215
Instructions(CodeSize): 3492232
Total(CodeSize): 4370108

rmacnak@prometheus:~/dart2/sdk$ cat snapshot.S | grep FFFF
Precompiled_FFFF_get_val_3488:
Precompiled_FFFF_init_theFFFF_3489:

[rmacnak, 2016-08-02 21:41:31]

Removed some now-redundant AddTypesOf(function)

[Florian Schneider, 2016-08-02 21:43:15]

LGTM

[rmacnak, 2016-08-02 23:31:01]

Description was changed from

==========
Tree-shaker: Use insertion in the work queue instead of "was compiled" as the
criterion to retain a function.

Allows dropping const constructors never used as non-const constructors nor
roots.
==========

to

==========
Tree-shaker: Use insertion in the work queue instead of "was compiled" as the
criterion to retain a function.

Allows dropping const constructors never used as non-const constructors nor
roots.

R=fschneider@google.com

Committed:
https://github.com/dart-lang/sdk/commit/908309fe6d239f80711ca4329367974c0265e52f
==========

[rmacnak, 2016-08-02 23:31:03]

Committed patchset #2 (id:20001) manually as
908309fe6d239f80711ca4329367974c0265e52f (presubmit successful).