Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(398)

Issue 2203823002: Handle the search box being detached from the NewTabPageView when calculating its offset. (Closed)

Created:
4 years, 4 months ago by Bernhard Bauer
Modified:
4 years, 4 months ago
Reviewers:
dgn
CC:
chromium-reviews, ntp-dev+reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Handle the search box being detached from the NewTabPageView when calculating its offset. BUG=yeah Committed: https://crrev.com/31bfef29d9829e355833328eefba40109a949796 Cr-Commit-Position: refs/heads/master@{#409562}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+10 lines, -3 lines) Patch
M chrome/android/java/src/org/chromium/chrome/browser/ntp/NewTabPageView.java View 1 chunk +10 lines, -3 lines 0 comments Download

Messages

Total messages: 12 (7 generated)
Bernhard Bauer
Please review. Thanks!
4 years, 4 months ago (2016-08-02 16:09:31 UTC) #4
dgn
lgtm
4 years, 4 months ago (2016-08-02 16:31:26 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203823002/1
4 years, 4 months ago (2016-08-03 16:21:33 UTC) #9
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-03 17:39:16 UTC) #10
commit-bot: I haz the power
4 years, 4 months ago (2016-08-03 17:41:19 UTC) #12
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/31bfef29d9829e355833328eefba40109a949796
Cr-Commit-Position: refs/heads/master@{#409562}

Powered by Google App Engine
This is Rietveld 408576698