Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(351)

Issue 2203793003: [ash-md] Properly scales windows with transient parents in overview (Closed)

Created:
4 years, 4 months ago by varkha
Modified:
4 years, 4 months ago
Reviewers:
CC:
chromium-reviews
Base URL:
https://chromium.googlesource.com/chromium/src.git@2785
Target Ref:
refs/pending/branch-heads/2785
Project:
chromium
Visibility:
Public.

Description

[ash-md] Properly scales windows with transient parents in overview Previously to this CL the code was only considering the focused window when calculating scale for the overview mode transform. It needs to consider the bounding rectangle of the whole transient parent's tree. BUG=632694 Review-Url: https://codereview.chromium.org/2197773002 Cr-Commit-Position: refs/heads/master@{#408763} (cherry picked from commit 0e4a6217e4694b15ba76a51b406254e9a4f22e1e) Committed: https://chromium.googlesource.com/chromium/src/+/149ce74ddadbf5cb76ee003d3088f46363bbe014

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+74 lines, -38 lines) Patch
M ash/common/wm/overview/scoped_transform_overview_window.h View 1 chunk +12 lines, -0 lines 0 comments Download
M ash/common/wm/overview/scoped_transform_overview_window.cc View 2 chunks +47 lines, -4 lines 0 comments Download
M ash/common/wm/overview/window_grid.cc View 2 chunks +1 line, -2 lines 0 comments Download
M ash/common/wm/overview/window_selector_item.h View 1 chunk +5 lines, -0 lines 0 comments Download
M ash/common/wm/overview/window_selector_item.cc View 4 chunks +9 lines, -32 lines 0 comments Download

Messages

Total messages: 4 (2 generated)
varkha
Committed patchset #1 (id:1) manually as 149ce74ddadbf5cb76ee003d3088f46363bbe014.
4 years, 4 months ago (2016-08-02 19:16:04 UTC) #1
varkha
4 years, 4 months ago (2016-08-02 19:16:51 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 (id:1) manually as
149ce74ddadbf5cb76ee003d3088f46363bbe014.

Powered by Google App Engine
This is Rietveld 408576698