Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(911)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 2203773002: Add support for "image-set"

Created:
4 years, 4 months ago by Sunil Ratnu
Modified:
4 years, 4 months ago
CC:
chromium-reviews, blink-reviews-css, dglazkov+blink, apavlov+blink_chromium.org, darktears, blink-reviews, rwlbuis
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Add support for "image-set" Add support for "image-set". Currently we only support "-webkit-image-set". Reference Webkit patch: https://trac.webkit.org/changeset/202765 BUG=630597

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+197 lines, -34 lines) Patch
M third_party/WebKit/LayoutTests/cssom/cssvalue-comparison.html View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/cssimagesetvalue-crash.html View 1 chunk +3 lines, -3 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/cursor-parsing-image-set.html View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/cursor-parsing-image-set-expected.txt View 2 chunks +5 lines, -5 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/image-set-parsing-expected.txt View 1 chunk +10 lines, -10 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/image-set-setting-expected.txt View 1 chunk +5 lines, -5 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/image-set-unprefixed.html View 1 chunk +100 lines, -0 lines 0 comments Download
A third_party/WebKit/LayoutTests/fast/css/image-set-unprefixed-expected.txt View 1 chunk +61 lines, -0 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/script-tests/image-set-parsing.js View 2 chunks +2 lines, -2 lines 0 comments Download
M third_party/WebKit/LayoutTests/fast/css/script-tests/image-set-setting.js View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSImageSetValue.cpp View 1 chunk +1 line, -1 line 0 comments Download
M third_party/WebKit/Source/core/css/CSSValueKeywords.in View 1 chunk +1 line, -0 lines 0 comments Download
M third_party/WebKit/Source/core/css/parser/CSSPropertyParser.cpp View 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 9 (4 generated)
Sunil Ratnu
Please have a look. Thanks!
4 years, 4 months ago (2016-08-02 16:32:12 UTC) #3
rwlbuis
Peer looks good to me.
4 years, 4 months ago (2016-08-02 17:41:50 UTC) #5
Sunil Ratnu
Please have a look. Thanks!
4 years, 4 months ago (2016-08-03 04:38:46 UTC) #7
Timothy Loh
On 2016/08/03 04:38:46, Sunil Ratnu wrote: > Please have a look. Thanks! This needs to ...
4 years, 4 months ago (2016-08-03 04:40:46 UTC) #8
Sunil Ratnu
4 years, 4 months ago (2016-08-08 05:37:54 UTC) #9 
On 2016/08/03 04:40:46, Timothy Loh wrote:
> On 2016/08/03 04:38:46, Sunil Ratnu wrote:
> > Please have a look. Thanks!
> 
> This needs to go through Blink's intent process. Please also verify that the
> implementation also matches the specification.
> 
> http://www.chromium.org/blink#launch-process

Thanks Tim for the review.
I have mailed an Intent to Implement and Ship to blink-dev.
Link:
https://groups.google.com/a/chromium.org/forum/#!topic/blink-dev/Tf5TwA45W8Q

Powered by Google App Engine
This is Rietveld 408576698