apps/pref_names.h - Issue 220373003: Prevent Chrome from quitting when apps are open. (Mac)

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: apps/pref_names.h

Issue 220373003: Prevent Chrome from quitting when apps are open. (Mac) (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 6 years, 8 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch | Annotate | Revision Log

OLD	NEW
1 // Copyright 2013 The Chromium Authors. All rights reserved.	1 // Copyright 2013 The Chromium Authors. All rights reserved.

2 // Use of this source code is governed by a BSD-style license that can be	2 // Use of this source code is governed by a BSD-style license that can be

3 // found in the LICENSE file.	3 // found in the LICENSE file.

4	4

5 #ifndef APPS_PREF_NAMES_H_	5 #ifndef APPS_PREF_NAMES_H_

6 #define APPS_PREF_NAMES_H_	6 #define APPS_PREF_NAMES_H_

7	7

8 namespace apps {	8 namespace apps {

9 namespace prefs {	9 namespace prefs {

10	10

11 // Alphabetical list of preference names specific to Apps component.	11 // Alphabetical list of preference names specific to Apps component.

12 // Keep alphabetized and document each one in the source file.	12 // Keep alphabetized and document each one in the source file.

13 extern const char kAppFullscreenAllowed[];	13 extern const char kAppFullscreenAllowed[];

	14 extern const char kNotifyWhenAppsKeepChromeAlive[];
	tapted 2014/04/01 08:09:45 I don't think the pref belongs in apps/ -- it's a I don't think the pref belongs in apps/ -- it's a very chromey thing, and src/apps is more for when apps stand alone from chrome. (maybe check with benwells) there's register prefs in browser_shutdown.h and background_mode_manager.h .. but none of those feel quite right. I think you can just add static member function like QuitWithAppsController::RegisterPrefs and put constants in chrome/common/pref_names.cc jackhou1 2014/04/02 06:38:38 Done. Show quoted text On 2014/04/01 08:09:45, tapted wrote: > I don't think the pref belongs in apps/ -- it's a very chromey thing, and > src/apps is more for when apps stand alone from chrome. (maybe check with > benwells) > > there's register prefs in browser_shutdown.h and background_mode_manager.h .. > but none of those feel quite right. > > I think you can just add static member function like > QuitWithAppsController::RegisterPrefs and put constants in > chrome/common/pref_names.cc > Done.
14	15

15 } // namespace prefs	16 } // namespace prefs

16 } // namespace apps	17 } // namespace apps

17	18

18 #endif // APPS_PREF_NAMES_H_	19 #endif // APPS_PREF_NAMES_H_

OLD	NEW

« no previous file with comments | « no previous file | apps/pref_names.cc » ('j') | chrome/browser/about_flags.cc » ('J')