Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(214)

Unified Diff: src/compiler/verifier.cc

Issue 2203693002: [turbofan] Introduce initial support for TypedArrays. (Closed) Base URL: https://chromium.googlesource.com/v8/v8.git@5254
Patch Set: Fix Retain Created 4 years, 5 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « src/compiler/typer.cc ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: src/compiler/verifier.cc
diff --git a/src/compiler/verifier.cc b/src/compiler/verifier.cc
index 6f82abf1860b1beed26acc73197f42b2663288ea..a41916eaee9eafd8dc1273fef57cad1a4a940ad3 100644
--- a/src/compiler/verifier.cc
+++ b/src/compiler/verifier.cc
@@ -650,11 +650,10 @@ void Verifier::Visitor::Check(Node* node) {
CheckNotTyped(node);
break;
- case IrOpcode::kDebugBreak:
- CheckNotTyped(node);
- break;
-
case IrOpcode::kComment:
+ case IrOpcode::kDebugBreak:
+ case IrOpcode::kRetain:
+ case IrOpcode::kUnsafePointerAdd:
CheckNotTyped(node);
break;
@@ -1042,6 +1041,8 @@ void Verifier::Visitor::Check(Node* node) {
// CheckValueInputIs(node, 0, Type::Object());
// CheckUpperIs(node, ElementAccessOf(node->op()).type));
break;
+ case IrOpcode::kLoadTypedElement:
+ break;
case IrOpcode::kStoreField:
// (Object, fieldtype) -> _|_
// TODO(rossberg): activate once machine ops are typed.
@@ -1058,6 +1059,9 @@ void Verifier::Visitor::Check(Node* node) {
// CheckValueInputIs(node, 1, ElementAccessOf(node->op()).type));
CheckNotTyped(node);
break;
+ case IrOpcode::kStoreTypedElement:
+ CheckNotTyped(node);
+ break;
case IrOpcode::kNumberSilenceNaN:
CheckValueInputIs(node, 0, Type::Number());
CheckUpperIs(node, Type::Number());
« no previous file with comments | « src/compiler/typer.cc ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698