Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(70)

Issue 2203623003: win: Remove unused function after https://codereview.chromium.org/2143893002 (Closed)

Created:
4 years, 4 months ago by Nico
Modified:
4 years, 4 months ago
CC:
chromium-reviews, grt+watch_chromium.org, pennymac+watch_chromium.org, wfh+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

win: Remove unused function after https://codereview.chromium.org/2143893002 Fixes a Wunused-function build error in official win builds with clang. BUG=600915, 82385 TBR=calamity@chromium.org Committed: https://chromium.googlesource.com/chromium/src/+/478bb211feab78414d71bc3f8774ec2ed10603e0

Patch Set 1 #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+0 lines, -4 lines) Patch
M chrome/installer/setup/app_launcher_installer.cc View 1 chunk +0 lines, -4 lines 1 comment Download

Messages

Total messages: 7 (3 generated)
Nico
4 years, 4 months ago (2016-08-02 11:10:01 UTC) #1
commit-bot: I haz the power
Patchset 1 (id:??) landed as https://crrev.com/478bb211feab78414d71bc3f8774ec2ed10603e0 Cr-Commit-Position: refs/heads/master@{#409171}
4 years, 4 months ago (2016-08-02 11:13:22 UTC) #3
Nico
Committed patchset #1 (id:1) manually as 478bb211feab78414d71bc3f8774ec2ed10603e0 (presubmit successful).
4 years, 4 months ago (2016-08-02 11:14:35 UTC) #5
grt (UTC plus 2)
4 years, 4 months ago (2016-08-02 13:26:31 UTC) #7
Message was sent while issue was closed.
https://codereview.chromium.org/2203623003/diff/1/chrome/installer/setup/app_...
File chrome/installer/setup/app_launcher_installer.cc (left):

https://codereview.chromium.org/2203623003/diff/1/chrome/installer/setup/app_...
chrome/installer/setup/app_launcher_installer.cc:39: return
GetLocalizedString(IDS_PRODUCT_APP_LAUNCHER_NAME_BASE);
calamity: looks like this string is unused altogether. please remove it from
create_string_rc.py and {chromium,google_chrome}_strings.grd. thanks.

Powered by Google App Engine
This is Rietveld 408576698