Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(769)

Issue 2203593002: Re-enable some PCv1 benchmarks for CrOS (Closed)

Created:
4 years, 4 months ago by kouhei (in TOK)
Modified:
4 years, 4 months ago
Reviewers:
nednguyen
CC:
chromium-reviews, telemetry-reviews_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Re-enable some PCv1 benchmarks for CrOS This CL re-enables page_cycler.intl_{ja_zh,es_fr_pt-BR,ar_fa_he} PCv1 benchmarks for ChromeOS This is a temporary solution until crbug.com/632815 is resolved TBR=nednguyen@google.com BUG=632815, 611329 Committed: https://crrev.com/f00d65e14a65a308a1f7b9e07c96859fff8b5280 Cr-Commit-Position: refs/heads/master@{#409108}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+49 lines, -0 lines) Patch
M tools/perf/benchmarks/page_cycler.py View 2 chunks +49 lines, -0 lines 0 comments Download

Messages

Total messages: 15 (9 generated)
kouhei (in TOK)
Ned, sorry for tbr-ing. This is basically a revert & cmtice@ wants this asap
4 years, 4 months ago (2016-08-01 22:22:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203593002/1
4 years, 4 months ago (2016-08-01 22:22:42 UTC) #6
nednguyen
lgtm I removed the extra try bot since that takes forever to run ~_~
4 years, 4 months ago (2016-08-02 01:01:35 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/v2/patch-status/codereview.chromium.org/2203593002/1
4 years, 4 months ago (2016-08-02 01:05:11 UTC) #11
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 4 months ago (2016-08-02 01:10:19 UTC) #13
commit-bot: I haz the power
4 years, 4 months ago (2016-08-02 01:13:11 UTC) #15
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/f00d65e14a65a308a1f7b9e07c96859fff8b5280
Cr-Commit-Position: refs/heads/master@{#409108}

Powered by Google App Engine
This is Rietveld 408576698