Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(7882)

Unified Diff: chrome/installer/mac/app/OmahaXMLParser.m

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added DMG to build file Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/mac/app/OmahaXMLParser.h ('k') | chrome/installer/mac/app/OmahaXMLRequest.m » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mac/app/OmahaXMLParser.m
diff --git a/chrome/installer/mac/app/OmahaXMLParser.m b/chrome/installer/mac/app/OmahaXMLParser.m
index d1a0a1d9101765e43c86c1e3ef5662031f390a06..fa901b2eb3a0f40b74dc4eb9903e6fc96be17c81 100644
--- a/chrome/installer/mac/app/OmahaXMLParser.m
+++ b/chrome/installer/mac/app/OmahaXMLParser.m
@@ -21,8 +21,6 @@
[parser setDelegate:omahaParser];
if (![parser parse]) {
*error = [parser parserError];
- // TODO: pass up error object to indicate error occurred so
- // InstallerWindowController can create custom user error message.
return nil;
}
@@ -34,6 +32,9 @@
}
if ([completeDownloadURLs count] < 1) {
+ // TODO: currently whatever error is passed in doesn't matter... we should
+ // make it so that the type of error informs what the installer will do
+ // about the error
*error = [NSError errorWithDomain:@"ChromeErrorDomain" code:1 userInfo:nil];
return nil;
}
« no previous file with comments | « chrome/installer/mac/app/OmahaXMLParser.h ('k') | chrome/installer/mac/app/OmahaXMLRequest.m » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698