Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(5002)

Unified Diff: chrome/installer/mac/app/BUILD.gn

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added DMG to build file Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/installer/mac/app/AppDelegate.m ('k') | chrome/installer/mac/app/Downloader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/installer/mac/app/BUILD.gn
diff --git a/chrome/installer/mac/app/BUILD.gn b/chrome/installer/mac/app/BUILD.gn
index c1ac141342302e8348427d7c21a893ff294414ed..912cfdfb8564b75a6b7846c92c193f72d90c1be2 100644
--- a/chrome/installer/mac/app/BUILD.gn
+++ b/chrome/installer/mac/app/BUILD.gn
@@ -6,23 +6,37 @@ import("//testing/test.gni")
import("//build/config/mac/rules.gni")
source_set("mac_installer_base") {
+ visibility = [ ":*" ]
sources = [
+ "Downloader.h",
"Downloader.m",
+ "NSAlert+ChromeInstallerAdditions.h",
"NSAlert+ChromeInstallerAdditions.m",
+ "NSError+ChromeInstallerAdditions.h",
"NSError+ChromeInstallerAdditions.m",
+ "OmahaCommunication.h",
"OmahaCommunication.m",
+ "OmahaXMLParser.h",
"OmahaXMLParser.m",
+ "OmahaXMLRequest.h",
"OmahaXMLRequest.m",
+ "SystemInfo.h",
"SystemInfo.m",
+ "Unpacker.h",
+ "Unpacker.m",
]
+ public_configs = [ "//build/config/compiler:enable_arc" ]
}
mac_app_bundle("mac_installer_app") {
info_plist = "Info.plist"
extra_substitutions = [ "MACOSX_DEPLOYMENT_TARGET=10.9" ]
sources = [
+ "AppDelegate.h",
"AppDelegate.m",
+ "AuthorizedInstall.h",
"AuthorizedInstall.m",
+ "InstallerWindowController.h",
"InstallerWindowController.m",
"main.m",
]
@@ -34,8 +48,8 @@ mac_app_bundle("mac_installer_app") {
]
libs = [
- "AppKit.framework",
- "CoreFoundation.framework",
+ "Cocoa.framework",
+ "DiskArbitration.framework",
"Security.framework",
]
}
@@ -59,6 +73,7 @@ test("mac_installer_unittests") {
sources = [
"testing/OmahaXMLRequest_test.mm",
"testing/SystemInfo_test.mm",
+ "testing/Unpacker_test.mm",
]
deps = [
":mac_installer_base",
@@ -66,10 +81,15 @@ test("mac_installer_unittests") {
"//base/test:run_all_unittests",
"//testing/gtest:gtest",
]
- libs = [ "Foundation.framework" ]
+ libs = [
+ "Cocoa.framework",
+ "DiskArbitration.framework",
+ "Security.framework",
+ ]
data = [
- "testing/requestCheck.dtd",
- "testing/requestSample.xml",
- "testing/responseExample.xml",
+ "//chrome/test/data/mac_installer/requestCheck.dtd",
+ "//chrome/test/data/mac_installer/requestSample.xml",
+ "//chrome/test/data/mac_installer/responseExample.xml",
+ "//chrome/test/data/mac_installer/test-dmg.dmg",
]
}
« no previous file with comments | « chrome/installer/mac/app/AppDelegate.m ('k') | chrome/installer/mac/app/Downloader.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698