chrome/installer/mac/app/OmahaXMLParser.h - Issue 2203583002: Added unpacking step

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/installer/mac/app/OmahaXMLParser.h

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Addressed all comments, rearranged app logic, rewrote test, a bit more error handling Created 4 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/installer/mac/app/OmahaXMLParser.h

diff --git a/chrome/installer/mac/app/OmahaXMLParser.h b/chrome/installer/mac/app/OmahaXMLParser.h

index 0454e1aab365fbcfcd687bdd39d4a5547d91b116..8cad7d9c262b4e3203e6df8c29c9fb3b9c8c4a58 100644

--- a/chrome/installer/mac/app/OmahaXMLParser.h

+++ b/chrome/installer/mac/app/OmahaXMLParser.h

@@ -9,8 +9,9 @@

@interface OmahaXMLParser : NSObject

-// Parses an XML document and extracts all the URLs found as well as the

-// filename. Adds each URL into the array chromeIncompleteDownloadURLs_.

+// Parses an XML document and extracts the URLs and name of the Chrome DMG from

+// Omaha, then returns an array with all the URLs concatenated with the

+// filename.

+ (NSArray*)parseXML:(NSData*)omahaResponseXML error:(NSError**)error;

@end