Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(367)

Side by Side Diff: chrome/installer/mac/app/BUILD.gn

Issue 2203583002: Added unpacking step (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Added use of temporary folders, removed semaphore from main installer code, adjusted some files' APIs, resolved remaining comments Created 4 years, 4 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 # Copyright 2016 The Chromium Authors. All rights reserved. 1 # Copyright 2016 The Chromium Authors. All rights reserved.
2 # Use of this source code is governed by a BSD-style license that can be 2 # Use of this source code is governed by a BSD-style license that can be
3 # found in the LICENSE file. 3 # found in the LICENSE file.
4 4
5 import("//testing/test.gni") 5 import("//testing/test.gni")
6 import("//build/config/mac/rules.gni") 6 import("//build/config/mac/rules.gni")
7 7
8 source_set("mac_installer_base") { 8 source_set("mac_installer_base") {
9 sources = [ 9 sources = [
10 "Downloader.m", 10 "Downloader.m",
11 "NSAlert+ChromeInstallerAdditions.m", 11 "NSAlert+ChromeInstallerAdditions.m",
12 "NSError+ChromeInstallerAdditions.m", 12 "NSError+ChromeInstallerAdditions.m",
13 "OmahaCommunication.m", 13 "OmahaCommunication.m",
14 "OmahaXMLParser.m", 14 "OmahaXMLParser.m",
15 "OmahaXMLRequest.m", 15 "OmahaXMLRequest.m",
16 "SystemInfo.m", 16 "SystemInfo.m",
17 "Unpacker.m",
17 ] 18 ]
18 } 19 }
19 20
20 mac_app_bundle("mac_installer_app") { 21 mac_app_bundle("mac_installer_app") {
21 info_plist = "Info.plist" 22 info_plist = "Info.plist"
22 extra_substitutions = [ "MACOSX_DEPLOYMENT_TARGET=10.9" ] 23 extra_substitutions = [ "MACOSX_DEPLOYMENT_TARGET=10.9" ]
23 sources = [ 24 sources = [
24 "AppDelegate.m", 25 "AppDelegate.m",
25 "InstallerWindowController.m", 26 "InstallerWindowController.m",
26 "main.m", 27 "main.m",
27 ] 28 ]
28 29
29 deps = [ 30 deps = [
30 ":mac_installer_base", 31 ":mac_installer_base",
31 ":mac_installer_xibs", 32 ":mac_installer_xibs",
32 ] 33 ]
33 34
34 libs = [ 35 libs = [
35 "AppKit.framework", 36 "Cocoa.framework",
Elly Fong-Jones 2016/08/16 15:26:18 I'm surprised we no longer need these frameworks?
Anna Zeng 2016/08/16 23:07:39 The Cocoa Framework includes AppKit, CoreFoundatio
36 "CoreFoundation.framework", 37 "DiskArbitration.framework",
37 ] 38 ]
38 } 39 }
39 40
40 mac_xib_bundle_data("mac_installer_xibs") { 41 mac_xib_bundle_data("mac_installer_xibs") {
41 sources = [ 42 sources = [
42 "MainMenu.xib", 43 "MainMenu.xib",
43 ] 44 ]
44 } 45 }
45 46
46 executable("mac_installer") {
47 sources = [
48 "main.m",
49 ]
50 deps = [
51 ":mac_installer_base",
52 ]
53
54 libs = [
55 "AppKit.framework",
56 "CoreFoundation.framework",
57 ]
58 }
59
60 test("mac_installer_unittests") { 47 test("mac_installer_unittests") {
61 sources = [ 48 sources = [
62 "testing/OmahaXMLRequest_test.mm", 49 "testing/OmahaXMLRequest_test.mm",
63 "testing/SystemInfo_test.mm", 50 "testing/SystemInfo_test.mm",
51 "testing/Unpacker_test.mm",
64 ] 52 ]
65 deps = [ 53 deps = [
66 ":mac_installer_base", 54 ":mac_installer_base",
67 "//base:base", 55 "//base:base",
68 "//base/test:run_all_unittests", 56 "//base/test:run_all_unittests",
69 "//testing/gtest:gtest", 57 "//testing/gtest:gtest",
70 ] 58 ]
71 libs = [ "Foundation.framework" ] 59 libs = [
60 "Cocoa.framework",
61 "DiskArbitration.framework",
62 ]
72 data = [ 63 data = [
73 "testing/requestCheck.dtd", 64 "testing/requestCheck.dtd",
74 "testing/requestSample.xml", 65 "testing/requestSample.xml",
75 "testing/responseExample.xml", 66 "testing/responseExample.xml",
76 ] 67 ]
77 } 68 }
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698