Added unpacking step

chrome/installer/mac/app/MainDelegate.m

 // Copyright 2016 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #import "MainDelegate.h"
 
+#import <AppKit/AppKit.h>
+
+extern dispatch_semaphore_t mount_semaphore;

[Sidney San Martín, 2016/08/08 18:43:17]

As discussed: a random extern definitely shouldn't be part of Unpacker's API,
you can just use delegate callbacks.

[Anna Zeng, 2016/08/12 22:56:18]

Done.

+
 @implementation MainDelegate
 
 - (void)runApplication {
   OmahaCommunication* messenger = [[OmahaCommunication alloc] init];
   messenger.delegate = self;
 
   [messenger sendRequest];
 }
 
 - (void)onOmahaSuccessWithResponseBody:(NSData*)responseBody
                               AndError:(NSError*)error {
   if (error) {
     NSLog(@"error: %@", [error localizedDescription]);
     exit(1);
   }
   Downloader* download = [[Downloader alloc] init];
   download.delegate = self;
 
   [download downloadChromeImageToDownloadsDirectory:responseBody];
 }
 
 - (void)onDownloadSuccess {
-  // TODO: replace the line of code below with real code someday to unpack dmg
+  Unpacker* unpack = [[Unpacker alloc] init];
+  unpack.delegate = self;
+  mount_semaphore = dispatch_semaphore_create(0);
+
+  [unpack mountDMG];
+  dispatch_semaphore_wait(mount_semaphore, DISPATCH_TIME_FOREVER);
+  [unpack unmountDMG];
+  dispatch_semaphore_wait(mount_semaphore, DISPATCH_TIME_FOREVER);

[Sidney San Martín, 2016/08/08 18:43:17]

As discussed:
1. mountDMG and unmountDMG are implementation details, they shouldn't be part of
Unpacker's API. Instead, it should just take a URL and a destination and call
back when it's done.
2. You shouldn't hold onto a thread for this. Use delegate callbacks.

[Anna Zeng, 2016/08/12 22:56:18]

#2 is taken care of; #1 is acknowledged and still being worked on.

+}
+
+- (void)onUnpackSuccess {
+  if (![[NSWorkspace sharedWorkspace] launchApplication:@"Google Chromo"]) {
+    NSLog(@"Chromo failed to launch");
+  }
   exit(0);
 }
 
-- (void)onUnpackSuccess {
-}
-
 @end